Bug #72258 unnecessary "set global innodb_monitor_enable = default" in some testcase
Submitted: 7 Apr 2014 6:15 Modified: 7 Apr 2014 7:28
Reporter: Tsubasa Tanaka (OCA) Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Server: Tests Severity:S3 (Non-critical)
Version:5.6.17 OS:Any
Assigned to: CPU Architecture:Any

[7 Apr 2014 6:15] Tsubasa Tanaka
Description:
Some testcase has"set global innodb_monitor_enable = default" statement with enclosing --disable_warnings and --enable_warnings, I think it may be purpose of "backing to innodb_monitor's status which mtr has started".

But "set global innodb_monitor_enable = default" statement always returns warning in current version and the statement doesn't change any innodb_monitor's status, thus, the statement doesn't satisfy it purpose.

How to repeat:
mysql56> SET GLOBAL innodb_monitor_enable  = default;
Query OK, 0 rows affected, 1 warning (0.37 sec)

mysql56> show warnings;
+---------+------+--------------------------------------------------------------------------------------------------+
| Level   | Code | Message                                                                                          |
+---------+------+--------------------------------------------------------------------------------------------------+
| Warning | 1230 | Default value is not defined for this set option. Please specify correct counter or module name. |
+---------+------+--------------------------------------------------------------------------------------------------+
1 row in set (0.06 sec)

And see

$ cd mysql-5.6.17/mysql-test
$ grep -ir innodb_monitor_enable * | grep -i default

Suggested fix:
Remove "set global innodb_monitor_enable = default" statement from testcases.
Or replace --disable_warnings to --error 1230.

ex.) mysql-test/suite/sys_vars/t/innodb_monitor_disable_basic.test
-- disable_warnings
set global innodb_monitor_enable = default;
set global innodb_monitor_disable = default;
set global innodb_monitor_reset = default;
set global innodb_monitor_reset_all = default;
-- enable_warnings

--error 1230
set global innodb_monitor_enable = default;
--error 1230
set global innodb_monitor_disable = default;
--error 1230
set global innodb_monitor_reset = default;
--error 1230
set global innodb_monitor_reset_all = default;

But this is nonsense fix because of these statements don't intend "returning error".
[7 Apr 2014 7:28] MySQL Verification Team
Hello Tsubasa,

Thank you for the bug report.
Verified as described.

Thanks,
Umesh