Bug #71680 Incomplete fix of "Bug #11765975 __FILE__ macros expanded to full path ..."
Submitted: 12 Feb 2014 11:00 Modified: 12 Feb 2014 11:23
Reporter: Hartmut Holzgraefe Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.6.16 OS:Any
Assigned to: CPU Architecture:Any

[12 Feb 2014 11:00] Hartmut Holzgraefe
Description:
At least one instance of 

  Bug #11765975 __FILE__ macros expanded to full path instead of relative
in CMake builds

was overlooked in 

  http://bazaar.launchpad.net/~mysql/mysql-server/5.6/revision/2875.248.1

which leads to output like this on long semaphore waits:

Last time read locked in file btr0cur.c line 3452
Last time write locked in file /home/hartmut/projects/mysql/releases/mysql-5.5.31/storage/innobase/row/row0ins.c line 2014

How to repeat:
Original fix around this messages was:

=== modified file 'storage/innobase/sync/sync0arr.c'
--- storage/innobase/sync/sync0arr.c    2011-01-18 10:30:33 +0000
+++ storage/innobase/sync/sync0arr.c    2011-02-24 03:03:24 +0000
@@ -533,7 +534,7 @@
                        (ulong) rw_lock_get_reader_count(rwlock),
                        (ulong) rwlock->waiters,
                        rwlock->lock_word,
-                       rwlock->last_s_file_name,
+                       innobase_basename(rwlock->last_s_file_name),
                        (ulong) rwlock->last_s_line,
                        rwlock->last_x_file_name,
                        (ulong) rwlock->last_x_line);

this overlooked the use of rwlock->last_x_file_name two lines down of rwlock->last_s_file_name

Suggested fix:
apply innobase_basename() to last_x_file_name, too
[12 Feb 2014 11:23] MySQL Verification Team
Thank you for the bug report.