MySQL Bugs: #70212: Unused function buf_flush_get_dirty_pages

Bug #70212	Unused function buf_flush_get_dirty_pages_count
Submitted:	2 Sep 2013 10:27	Modified:	2 Sep 2013 11:16
Reporter:	Laurynas Biveinis (OCA)	Email Updates:
Status:	Verified	Impact on me:	None
Category:	MySQL Server: InnoDB storage engine	Severity:	S3 (Non-critical)
Version:	5.6	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
Function buf_flush_get_dirty_pages_count() is defined but not used anywhere.

How to repeat:
5.6$ grep -r buf_flush_get_dirty_pages_count *

storage/innobase/buf/buf0flu.cc:buf_flush_get_dirty_pages_count(
storage/innobase/include/buf0flu.h:buf_flush_get_dirty_pages_count(

Suggested fix:
Remove it.

buf_pool_get_dirty_pages_count() then becomes used from buf0lru.cc only, maybe can be moved there and made static.

Hello Laurynas,

Thank you for the bug report. 
Verified as described.

Thanks,
Umesh