MySQL Bugs: #68133: Leftover prototype for the removed srv_parse_log_group_home

Bug #68133	Leftover prototype for the removed srv_parse_log_group_home_dirs()
Submitted:	21 Jan 2013 14:54	Modified:	20 Apr 2013 13:19
Reporter:	Laurynas Biveinis (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: InnoDB storage engine	Severity:	S4 (Feature request)
Version:	5.6.9	OS:	Any
Assigned to:		CPU Architecture:	Any

Description:
5.6$ grep -R srv_parse_log_group_home_dirs *
storage/innobase/srv/srv0start.cc:and srv_parse_log_group_home_dirs(). */
storage/innobase/include/srv0start.h:srv_parse_log_group_home_dirs(
storage/innobase/include/srv0start.h:and srv_parse_log_group_home_dirs(). */

The middle match shows the prototype in srv0start.h

/*********************************************************************//**
Reads log group home directories from a character string given in
the .cnf file.
@return	TRUE if ok, FALSE on parse error */
UNIV_INTERN
ibool
srv_parse_log_group_home_dirs(
/*==========================*/
	char*	str);	/*!< in/out: character string */

This is a leftover from http://lists.mysql.com/commits/144854 and should be removed.

The other two hits are in the header comment of srv_free_paths_and_sizes(), which should be edited to match.

How to repeat:
Grep, read, etc.

Suggested fix:
Remove the srv_parse_log_group_home_dirs prototype, edit the header comment for srv_free_paths_and_sizes().

Thanks for this code cleanup request !

Added changelog entry to 5.6.11, 5.7.1.

This fix removes left-over prototype code for
"srv_parse_log_group_home_dirs", and related header comments.

$ bzr log -r 4674.1.6
------------------------------------------------------------
revno: 4674.1.6
committer: Marko Mäkelä <marko.makela@oracle.com>
branch nick: mysql-5.6
timestamp: Mon 2013-01-28 13:23:26 +0200
message:
  Bug#16198764 LEFTOVER PROTOTYPE FOR THE REMOVED SRV_PARSE_LOG_GROUP_HOME_DIRS()

The source comments that reference the removed function still remain.