MySQL Bugs: #63275: long sleep in srv_monitor

Bug #63275	long sleep in srv_monitor_thread can delay shutdown
Submitted:	16 Nov 2011 0:04	Modified:	16 Nov 2011 15:54
Reporter:	Mark Callaghan	Email Updates:
Status:	Verified	Impact on me:	None
Category:	MySQL Server: InnoDB Plugin storage engine	Severity:	S3 (Non-critical)
Version:	5.1.52	OS:	Any
Assigned to:		CPU Architecture:	Any
Tags:	innodb, shutdown, slow

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
srv_monitor_thread has this code that can delay shutdown by 5 seconds.

        /* Wake up every 5 seconds to see if we need to print
        monitor information. */

        os_thread_sleep(5000000);

I think it is better to sleep at most 1 second before checking for shutdown.

How to repeat:
read the source

Suggested fix:
Sleep 1 second, check srv_shutdown_state, repeat

Thank you for the problem report. Probably we just need to backport fix from bug #55681 to 5.1.

I don't think you need to backport it to 5.1. A fix in 5.6 and 5.5 is good enough for me.