Description:
There are three screens that should be skipped if they do not do anything on the installation process:
Check Requirements : If there are no dependencies just skip this screen
Installation Progress : If nothing was selected just skip this screen
Configuration Overview : If on the selected packages none requires configuration just skip this screen.
This could be seen either as a bug ( showing unneeded screens ) or as a usability enhancement, in any form, users don´t have to go through all those screens if not needed.
How to repeat:
The easiest one : Start the wizard and just click on the Next button without selecting any package... you'll go through all the screens and get a final one indicating the installation was completed.
Suggested fix:
Make some validations available to the InstallWizardControl.cs so it can use them to decide what's the next screen to be shown, like adding some methods like the next ones on ProductManager.cs, and then use them on InstallWizardControl.cs on Next_Click in order to determine which is the next screen to be shown according to the configuration being installed:
public static bool ChangesNeeded()
{
bool ret_val = false;
foreach (ProductCategory pc in ProductManager.ProductCategories)
{
foreach (Product p in pc.Products)
{
// In order to support per-feature changes we must check such changes independently of
// the installation proposal for their owning product.
if ((p.ProposedInstalled && p.IsUpgrade) || p.HasChanges())
ret_val = true;
}
}
return ret_val;
}
public static bool ConfigurationNeeded()
{
bool ret_val = false;
foreach (ProductCategory pc in ProductManager.ProductCategories)
{
foreach (Product p in pc.Products)
{
if (p.CurrentState == ProductState.InstallSuccess && p.Controller != null)
ret_val = true;
}
}
return ret_val;
}
public static bool PrerequisitesNeeded()
{
...
}
Description: There are three screens that should be skipped if they do not do anything on the installation process: Check Requirements : If there are no dependencies just skip this screen Installation Progress : If nothing was selected just skip this screen Configuration Overview : If on the selected packages none requires configuration just skip this screen. This could be seen either as a bug ( showing unneeded screens ) or as a usability enhancement, in any form, users don´t have to go through all those screens if not needed. How to repeat: The easiest one : Start the wizard and just click on the Next button without selecting any package... you'll go through all the screens and get a final one indicating the installation was completed. Suggested fix: Make some validations available to the InstallWizardControl.cs so it can use them to decide what's the next screen to be shown, like adding some methods like the next ones on ProductManager.cs, and then use them on InstallWizardControl.cs on Next_Click in order to determine which is the next screen to be shown according to the configuration being installed: public static bool ChangesNeeded() { bool ret_val = false; foreach (ProductCategory pc in ProductManager.ProductCategories) { foreach (Product p in pc.Products) { // In order to support per-feature changes we must check such changes independently of // the installation proposal for their owning product. if ((p.ProposedInstalled && p.IsUpgrade) || p.HasChanges()) ret_val = true; } } return ret_val; } public static bool ConfigurationNeeded() { bool ret_val = false; foreach (ProductCategory pc in ProductManager.ProductCategories) { foreach (Product p in pc.Products) { if (p.CurrentState == ProductState.InstallSuccess && p.Controller != null) ret_val = true; } } return ret_val; } public static bool PrerequisitesNeeded() { ... }