MySQL Bugs: #60542: rpl.rpl_extra_col_master_* doesn't test what was intended

Bug #60542	rpl.rpl_extra_col_master_* doesn't test what was intended
Submitted:	19 Mar 2011 1:20	Modified:	17 Jan 2012 12:14
Reporter:	Justin Tolmer	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tests: Replication	Severity:	S3 (Non-critical)
Version:	5.1.56, 5.1.57	OS:	Any
Assigned to:		CPU Architecture:	Any

Description:
The tests

    rpl.rpl_extra_col_master_innodb
    rpl.rpl_extra_col_master_myisam

are trying to test all binlog formats by doing:

    set binlog_format=row;
    -- source extra/rpl_tests/rpl_extra_col_master.test

    set binlog_format=statement;
    -- source extra/rpl_tests/rpl_extra_col_master.test

    set binlog_format=mixed;
    -- source extra/rpl_tests/rpl_extra_col_master.test

However, when extra/rpl_tests/rpl_extra_col_master.test ends the active connection is the slave connection. Thus, the 2 tests never succeed in changing the binlog format of the master away from 'row'. If the test is fixed so that it correct sets the master's binlog format the tests fail for both 'statement' and 'mixed'.

Additionally, there is no reason for the tests to be explicitly setting the binlog format in this way because mysql-test/suite/rpl/combinations will automatically run the test for all 3 binlog formats.

How to repeat:
Any of the following:

* Examine the source of extra/rpl_tests/rpl_extra_col_master.test and see that it leaves the active connection as the slave.

* Add 'select @@server_id;' as the last line of extra/rpl_tests/rpl_extra_col_master.test and notice that it is 2 in the generated output.

* Change the tests to explicitly set 'connection master' prior to setting binlog_format, run the tests and they will fail.

Thank you for the report.

Verified as described. This is fixed in version 5.5

Thank you for your bug report. This issue has already been fixed in the latest released version of that product, which you can download at

  http://www.mysql.com/downloads/

Affects tests only--no changelog entry required.