MySQL Bugs: #60515: 'Open diagram tabs from previous save' functionality is broken again

Bug #60515	'Open diagram tabs from previous save' functionality is broken again
Submitted:	17 Mar 2011 14:57	Modified:	29 Nov 2011 5:35
Reporter:	Craig Fowler	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench	Severity:	S3 (Non-critical)
Version:	5.2.33	OS:	Linux (Debian Testing, 64-bit using Ubuntu 10.04 .deb package)
Assigned to:		CPU Architecture:	Any
Tags:	regression, UI

Description:
This appears to be a regression (of sorts) from #44454 and #50732 - the functionality that saves the state of open diagrams has stopped working in .33.

It actually appears that the "open tabs" state is being saved correctly when a file is first saved but when overwriting an existing saved file the information is not recorded again.

How to repeat:
* Create a new Workbench model.
* Create two diagrams in that model named "Foo" and "Bar".
* Save the model for the first time with both diagrams open.
* Close Workbench and then re-open the project file - both diagrams "Foo" and "Bar" are opened.
* Close the diagram "Foo" and save the project file (I saved via Ctrl-S).
* Close Workbench and then re-open the project file - you would expect to see only the diagram "Bar" opened.

Instead, both the diagrams "Foo" and "Bar" are opened automatically.

Thank you for the bug report.

Two things:  This bug still exists in 5.2.35pre22 and also a workaround I have discovered (but not for the faint of heart):

If you unwrap the WB project file (it's really just a ZIP file) and then perform a find/replace through the XML file for the string:

<value type="int" key="closed">0</value>

replacing the zero in that string with a 1 then (on re-zipping up the extracted project and renaming back to .mwb) it seems to close down all of your diagrams without further consequence.

It seems that this "closed" state is what is not being saved for diagrams that are newly created, or closed during a session working with WB.

Fixed as of 5.2.36:
+        Open diagram tabs from a saved &workbench; state were not saved
+        properly.