| Bug #6023 | strings/str_test is out of date | ||
|---|---|---|---|
| Submitted: | 11 Oct 2004 12:21 | Modified: | 11 Oct 2004 21:32 |
| Reporter: | Marko Mäkelä | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server | Severity: | S3 (Non-critical) |
| Version: | 4.1.6-bk | OS: | Linux (GNU/Linux) |
| Assigned to: | Sergei Golubchik | CPU Architecture: | Any |
[11 Oct 2004 21:32]
Sergei Golubchik
I fixed that typo in 5.0 already (just found it 30 min ago :) another "typo" is undefined $(FLAGS) which also prevented the test binary from compiling (see mysys/Makefile.am for FLAGS)
Description: The test program strings/str_test cannot be compiled due to a typo in strings/Makefile.am: str_test: str_test.c $(LIBRARIES) $(LINK) $(FLAGS) -DMAIN $INCLUDES $(srcdir)/str_test.c $(LDADD) $(LIBS)\ $(pkglib_LIBRARIES) How to repeat: cd strings make str_test Suggested fix: The string $INCLUDES in strings/Makefile.am should be replaced with $(INCLUDES). Furthermore, new tests should be added to the file str_test.c. For instance, there is nothing that covers the utf8 string functions. (I saw something at the end of ctype-utf8.c, but it wasn't obvious how the test code can be compiled and linked into a stand-alone program.)