Bug #60225 Unused mutex commit_threads_m

• Submitted: 23 Feb 2011 17:52
• Modified: 25 Jun 2013 13:11
• Reporter: Linhai Song
• Status: Closed
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: mysql-5.0.15, 5.5.11, mysql-6.0.11-alpha
• OS: Any
• Assigned to: Inaam Rana
• CPU Architecture: Any
• Tags: performance

[23 Feb 2011 17:52] Linhai Song

Description:
The following mutexes:

pthread_mutex_t commit_threads_m  

is initialized and destroyed, but never locked / unlocked in the server code.

How to repeat:
code review 

Suggested fix:
delete

[23 Feb 2011 18:22] Valeriy Kravchuk

Verified by code review:

macbook-pro:mysql-5.5 openxs$ grep -rn commit_threads_m *
storage/innobase/handler/ha_innodb.cc:103:static mysql_mutex_t commit_threads_m;
storage/innobase/handler/ha_innodb.cc:219:static mysql_pfs_key_t	commit_threads_m_key;
storage/innobase/handler/ha_innodb.cc:224:        {&commit_threads_m_key, "commit_threads_m", 0},
storage/innobase/handler/ha_innodb.cc:2509:	mysql_mutex_init(commit_threads_m_key,
storage/innobase/handler/ha_innodb.cc:2510:			 &commit_threads_m, MY_MUTEX_INIT_FAST);
storage/innobase/handler/ha_innodb.cc:2560:		mysql_mutex_destroy(&commit_threads_m);

[25 Jun 2013 13:11] Bugs System

Added a changelog entry for 5.1.71, 5.5.33, 5.6.13, 5.7.2:

"The "pthread_mutex", "commit_threads_m", which was initialized but never
used, has been removed from the code base."

Thank you for the bug report.