Bug #60128 Add performance schema instrumentation on os_fast_mutex

• Submitted: 15 Feb 2011 7:22
• Modified: 15 Feb 2011 7:24
• Reporter: Jimmy Yang
• Status: Patch queued
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• OS: Any
• Assigned to: Assigned Account
• CPU Architecture: Any
• Tags: 5.6

[15 Feb 2011 7:22] Jimmy Yang

Description:
There are about 5 mutexes that are using os_fast_mutex interfaces. We did not instrument them similarly as InnoDB mutex since they were not target of study. With recent study on concurrency connections, ranger had a request to include mutex srv_conc_mutex. So I just add the instrumentation interface to os_fast_mutex. And following 4 mutexes are instrumented:

       {&event_os_mutex_key, "event_os_mutex", 0},
       {&os_mutex_key, "os_mutex", 0},
       {&srv_conc_mutex_key, "srv_conc_mutex", 0},
       {&ut_list_mutex_key, "ut_list_mutex", 0}

Two mutex are  still marked as PFS_NOT_INSTRUMENTED since they are not providing a lot value:

srv/srv0start.c:    os_fast_mutex_init(PFS_NOT_INSTRUMENTED, &srv_os_test_mutex);
sync/sync0sync.c:    os_fast_mutex_init(PFS_NOT_INSTRUMENTED, &(mutex->os_fast_mutex)); 

How to repeat:
Code review

Suggested fix:
Add the instrumentation

[4 Mar 2016 2:16] Daniel Black

fast mutexes where removed in b1ae5c5954a388aeceef98c57982c5a602471eff (http://bugs.mysql.com/bug.php?id=72807).

This probably can be closed.