Bug #59811 Re-instate procedure mtr.force_restart in MTR, removed by 49978
Submitted: 29 Jan 2011 15:11 Modified: 31 Aug 2011 14:43
Reporter: Bjørn Munch Email Updates:
Status: Closed Impact on me:
None 
Category:Tools: MTR / mysql-test-run Severity:S7 (Test Cases)
Version:5.1+ OS:Any
Assigned to: Sven Sandberg CPU Architecture:Any

[29 Jan 2011 15:11] Bjørn Munch 
Description:
I've had a report of massive test failures after 5.1 was merged into another tree, caused by the missing procedure mtr.force_restart.

How to repeat:
Run any test that tries to do

call mtr.force_restart();

, as per the MTR user docs.

Suggested fix:
Put back the code defining the procedure that was removed as part of the major fic in Bug #49978. This is a documented feature and should NOT have been removed!
[31 Jan 2011 9:04] Sven Sandberg 
The removal of mtr.force_restart was intentional. It has been replaced by include/force_restart.inc. So to fix the failing tree, just do this for each file:

sed 's/call mtr.force_restart()/source include\/force_restart.inc/i'
[31 Jan 2011 9:40] Bjørn Munch 
Changing existing tests is one thing, but removing a *documented* feature is not acceptable. There are people out there who read the docs and write tests based on it, and they should expect things to work, and to not suddenly break after an update.
[31 Aug 2011 14:43] Paul DuBois 
Changes to test suite. No changelog entry needed.