Bug #59707 Unused compression-related parameters in buffer pool functions

• Submitted: 25 Jan 2011 7:43
• Modified: 10 Feb 2011 23:36
• Reporter: Marko Mäkelä
• Status: Closed
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: 5.1 plugin, 5.5+
• OS: Any (all)
• Assigned to: Marko Mäkelä
• CPU Architecture: Any
• Tags: compression, innodb

[25 Jan 2011 7:43] Marko Mäkelä

Description:
There are some redundant function parameters related to InnoDB compression:

buf_block_alloc(): ulint zip_size is always 0
buf_LRU_get_free_block(): ulint zip_size is always 0
buf_LRU_free_block(): ibool* buf_pool_mutex_released is always NULL

How to repeat:
Read the code.

Suggested fix:
Replace the parameters with constants and simplify the code.

[25 Jan 2011 7:57] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/129510

[25 Jan 2011 7:57] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/129509

[30 Jan 2011 16:58] Bugs System

Pushed into mysql-5.1 5.1.56 (revid:[e-mail]-20110130164158-1q99a41kb2wvkw3a) (version source revid:[e-mail]-20110130164158-1q99a41kb2wvkw3a) (merge vers: 5.1.56) (pib:24)

[30 Jan 2011 16:59] Bugs System

Pushed into mysql-trunk 5.6.2 (revid:[e-mail]-20110130165639-1pr3opz839b98q5j) (version source revid:[e-mail]-20110130165522-m0o6al0pn5ig9kv3) (merge vers: 5.6.2) (pib:24)

[30 Jan 2011 17:00] Bugs System

Pushed into mysql-5.5 5.5.10 (revid:[e-mail]-20110130165343-he9art47agq1a3gr) (version source revid:[e-mail]-20110130165137-5lvzsq9j29j0hp1s) (merge vers: 5.5.10) (pib:24)