MySQL Bugs: #57947: InnoDB diagnostics shows btr_block

Bug #57947	InnoDB diagnostics shows btr_block_get calls instead of real callers
Submitted:	3 Nov 2010 8:46	Modified:	14 Dec 2010 19:02
Reporter:	Marko Mäkelä	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: InnoDB storage engine	Severity:	S3 (Non-critical)
Version:	all	OS:	Any
Assigned to:	Marko Mäkelä	CPU Architecture:	Any
Tags:	btr_block_get, btr0btr.ic, innodb, semaphore wait

Description:
I noticed this while working on a fix of Bug #55284.

The InnoDB rw-lock diagnostics refers to the buf_page_get() invocation in btr_block_get(). There are many callers to btr_block_get(). It would be more useful to record the file name and line number of the caller of btr_block_get().

How to repeat:
Watch the diagnostic output, e.g., the one for long semaphore waits.

Suggested fix:
Replace btr_block_get() and btr_page_get() with macros that pass the file names and line numbers of the callers to buf_page_get_gen().

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122608

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122609

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122615

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122616

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122621

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122622

Pushed into mysql-trunk 5.6.1 (revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (version source revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

Pushed into mysql-5.1 5.1.55 (revid:sunanda.menon@oracle.com-20101215054055-vgwki317xg1wphhh) (version source revid:sunanda.menon@oracle.com-20101215054055-vgwki317xg1wphhh) (merge vers: 5.1.55) (pib:23)

Pushed into mysql-5.5 5.5.9 (revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (version source revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)