Bug #57802 Empty ASSERTION parameter passed to the HASH_SEARCH macro

• Submitted: 28 Oct 2010 11:13
• Modified: 11 Jan 2011 0:53
• Reporter: Marko Mäkelä
• Status: Closed
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: 5.1 plugin, 5.5+
• OS: Any
• Assigned to: Marko Mäkelä
• CPU Architecture: Any
• Tags: assertion, innodb, UNIV_DEBUG

[28 Oct 2010 11:13] Marko Mäkelä

Description:
In the InnoDB Plugin 1.0, the HASH_SEARCH macro was extended with an ASSERTION parameter that is checked in debug builds. An empty parameter is passed in thr0loc.c and thr0i_s.c, which can cause compilation warnings.

Every module should have some debug assertions or validation.

How to repeat:
Read the HASH_SEARCH invocations in thr0loc.c and thr0i_s.c.

Suggested fix:
Add the missing assertions.

[11 Nov 2010 9:56] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123556

[11 Nov 2010 9:56] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123557

[11 Nov 2010 13:13] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123606

[11 Nov 2010 13:13] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123607

[1 Dec 2010 8:02] Marko Mäkelä

Sunny Bains noticed that this introduced Bug #58623: Bogus debug assertion failure in i_s_locks_row_validate().

[5 Dec 2010 12:42] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (version source revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

[15 Dec 2010 5:51] Bugs System

Pushed into mysql-5.1 5.1.55 (revid:[e-mail]-20101215054055-vgwki317xg1wphhh) (version source revid:[e-mail]-20101215054055-vgwki317xg1wphhh) (merge vers: 5.1.55) (pib:23)

[16 Dec 2010 22:33] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20101216101358-fyzr1epq95a3yett) (version source revid:[e-mail]-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)

[22 Dec 2010 21:30] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101222212842-y0t3ibtd32wd9qaw) (version source revid:[e-mail]-20101222212842-y0t3ibtd32wd9qaw) (merge vers: 5.6.1) (pib:24)

[8 Jan 2011 15:09] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20110108150508-gpanhz48z8069qot) (version source revid:[e-mail]-20110108150048-b1y9m8xe72hay0ch) (merge vers: 5.5.9) (pib:24)

[8 Jan 2011 15:11] Bugs System

Pushed into mysql-5.1 5.1.55 (revid:[e-mail]-20110108145923-0tjqdpa5w3d6tuwn) (version source revid:[e-mail]-20110108145923-0tjqdpa5w3d6tuwn) (merge vers: 5.1.55) (pib:24)