Bug #57736 Remove unused OPT_NDB* from client_priv.h

• Submitted: 26 Oct 2010 12:30
• Modified: 15 Dec 2010 0:43
• Reporter: Magnus Blåudd
• Status: Closed
• Category: MySQL Server: General
• Severity: S3 (Non-critical)
• Version: 5.5
• OS: Any
• Assigned to: Magnus Blåudd
• CPU Architecture: Any
• Tags: SEAGULL

[26 Oct 2010 12:30] Magnus Blåudd

Description:
There are unused OPT_NDB* items in the  options_client enum in client/client_priv.h and these can be removed.

How to repeat:
MCI

Suggested fix:
=== modified file 'client/client_priv.h'
--- client/client_priv.h	2010-07-15 11:13:30 +0000
+++ client/client_priv.h	2010-10-26 12:26:45 +0000
@@ -50,9 +50,6 @@
   OPT_OPEN_FILES_LIMIT, OPT_SET_CHARSET, OPT_SERVER_ARG,
   OPT_STOP_POSITION, OPT_START_DATETIME, OPT_STOP_DATETIME,
   OPT_SIGINT_IGNORE, OPT_HEXBLOB, OPT_ORDER_BY_PRIMARY, OPT_COUNT,
-#ifdef HAVE_NDBCLUSTER_DB
-  OPT_NDBCLUSTER, OPT_NDB_CONNECTSTRING,
-#endif
   OPT_TRIGGERS,
   OPT_MYSQL_ONLY_PRINT,
   OPT_MYSQL_LOCK_DIRECTORY,

[26 Oct 2010 12:59] Valeriy Kravchuk

As far as I can see (in mysql-next-mr tree at least) OPT_NDBCLUSTER is not used in the code. But OPT_NDB_CONNECTSTRING is used in ndb_opts.h at least.

[27 Oct 2010 9:34] Magnus Blåudd

True, but that is a different OPT_NDB_CONNECTSTRING defined locally in ndb_opts.h

[27 Oct 2010 12:33] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122088

[5 Dec 2010 12:37] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (version source revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

[15 Dec 2010 0:43] Paul DuBois

Code cleanup, no changelog entry needed.