| Bug #57713 | Add extra configure arguments to BUILD/* | ||
|---|---|---|---|
| Submitted: | 25 Oct 2010 13:57 | Modified: | 5 Feb 2013 10:30 |
| Reporter: | Magnus Blåudd | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Compiling | Severity: | S3 (Non-critical) |
| Version: | OS: | Any | |
| Assigned to: | CPU Architecture: | Any | |
| Tags: | SEAGULL | ||
[25 Oct 2010 14:02]
Valeriy Kravchuk
Thank you for the feature request.
[16 Dec 2010 10:11]
Joerg Bruehe
"BUILD/*" scripts do not have any assigned owner AFAIK, they are not supported officially (so there is no documented behaviour which must not change), they exist just for the convenience of (internal or external) developers. I do not see how the proposed patch would cause any losses to current behaviour, so I don't see any reasons against it. I propose you double-check it does what you want it to do, select the oldest version you see a need to get it in, and document this here. Don't forget we switched to "cmake" for 5.5 and up, so either verify it works there as well or ensure a null-merge (at your preference). Then, commit a changeset and ask for reviews.
[5 Feb 2013 10:30]
Erlend Dahl
[4 Feb 2013 3:32] Magnus Blaudd (MBLAUDD) Fixed by storage/ndb/compile-cluster
Description: Add support for adding extra configure arguments to BUILD/ Example: BUILD/compile-pentium-debug -- <extra-configure-args> How to repeat: . Suggested fix: === modified file 'BUILD/FINISH.sh' --- BUILD/FINISH.sh 2010-07-22 11:30:14 +0000 +++ BUILD/FINISH.sh 2010-10-25 13:27:54 +0000 @@ -15,7 +15,7 @@ if [ -z "$just_clean" ] then commands="$commands CC=\"$CC\" CFLAGS=\"$cflags\" CXX=\"$CXX\" CXXFLAGS=\"$cxxflags\" CXXLDFLAGS=\"$CXXLDFLAGS\" \ -$configure" +$configure $extra_configure" fi if [ -z "$just_configure" -a -z "$just_clean" ] === modified file 'BUILD/SETUP.sh' --- BUILD/SETUP.sh 2010-08-06 12:59:38 +0000 +++ BUILD/SETUP.sh 2010-10-25 13:54:31 +0000 @@ -10,13 +10,14 @@ get_key_value() usage() { cat <<EOF -Usage: $0 [-h|-n] [configure-options] +Usage: $0 [-h|-n] [configure-options] [ -- -extra-configure-options ] -h, --help Show this help message. -n, --just-print Don't actually run any commands; just print them. -c, --just-configure Stop after running configure. --warning-mode=[old|pedantic|maintainer] Influences the debug flags. Old is default. --prefix=path Build with prefix 'path'. + -- Options after this is passed through to configure Note: this script is intended for internal use by MySQL developers. EOF @@ -38,6 +39,10 @@ parse_options() -h | --help) usage exit 0;; + --) + shift; + extra_configure=$*; + break;; *) echo "Unknown option '$1'" exit 1;; @@ -59,6 +64,7 @@ just_print= just_configure= warning_mode= maintainer_mode= +extra_configure= parse_options "$@"