Bug #57478 compiler warning in mysqltest.cc, one comma to many

• Submitted: 15 Oct 2010 8:53
• Modified: 18 Oct 2010 9:01
• Reporter: Magnus Blåudd
• Status: Can't repeat
• Category: Tools: MTR / mysql-test-run
• Severity: S3 (Non-critical)
• Version: 5.1.53
• OS: Any
• Assigned to: Bjørn Munch
• CPU Architecture: Any

[15 Oct 2010 8:53] Magnus Blåudd

Description:
client/mysqltest.cc: 2266
	missing braces around initializer for ‘const command_arg’

How to repeat:
Compile MySQL Server with "gcc (GCC) 4.4.2 20091027 (Red Hat 4.4.2-7)" using 
CFLAGS="-O3 -Wall -g -fno-omit-frame-pointer" CXXFLAGS="-O3 -Wall -g
-fno-omit-frame-pointer" ./configure --prefix=/usr/local/mysql
--localstatedir=/usr/local/mysql/data --libexecdir=/usr/local/mysql/bin 
--with-extra-charsets=all --enable-thread-safe-client --enable-local-infile
--with-zlib-dir=bundled --with-big-tables --with-readline --with-archive-storage-engine
--with-plugins=max --with-embedded-server

Suggested fix:
=== modified file 'client/mysqltest.cc'
--- a/client/mysqltest.cc	2010-10-12 11:54:35 +0000
+++ b/client/mysqltest.cc	2010-10-14 16:22:13 +0000
@@ -2262,7 +2262,7 @@ do_result_format_version(struct st_comma
   long version;
   static DYNAMIC_STRING ds_version;
   const struct command_arg result_format_args[] = {
-    "version", ARG_STRING, TRUE, &ds_version, "Version to use",
+    "version", ARG_STRING, TRUE, &ds_version, "Version to use"
   };

[15 Oct 2010 14:05] Bjørn Munch

This bug does not exist; the offending comma was removed in 5.5 main branch on 2009-12-22. The affected code is not even present in 5.1.