MySQL Bugs: #57055: agent update installer switches off an existing proxy when using update defaults

Bug #57055	agent update installer switches off an existing proxy when using update defaults
Submitted:	28 Sep 2010 8:41	Modified:	1 Oct 2010 21:49
Reporter:	Carsten Segieth	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Installing	Severity:	S3 (Non-critical)
Version:	2.3.0.2025	OS:	Any
Assigned to:	BitRock Merlin	CPU Architecture:	Any

Description:
Using the defaults the update installer switches off an installed proxy in unattended mode, which may break setups which are using the proxy.

The problem seem to be that the default value for '--enableproxy' is '0' and if one updates the agent with proxy enabled the proxy will be switched off if the option is not set on the command line in unattended install or if the user clicks 'too fast' through the UI / text update install and does not notice that the installer changed the proxy setting from "ON" (as it was installed) to "OFF".

How to repeat:
install e.g. 2.2.2.1729 with enabled proxy and update to 2.3.0.2025 using the defaults with a command line like shown:

# on net-qa1
UPD=2.2.2.1729
VER=2.3.0.2025
INSTALLDIR=/data0/merlin/agent/updtest/rhel4-x86-32bit/net-qa1
/nfstmp2/merlin/packages/${UPD}/agents/mysqlmonitoragent-${UPD}-linux-glibc2.3-x86-32bit-installer.bin --installdir ${INSTALLDIR}  --mysqlhost 127.0.0.1 --mysqlport 43300 --mysqluser agent --mysqlpassword mysql --checkmysqlhost yes --managerhost 127.0.0.1 --managerport 48080 --agentuser pino_user --agentpassword pino_pwd --proxyport 44044 --enableproxy 1 --createaccount 0 --mode unattended
cd ${INSTALLDIR}
cp -pr etc etc.${UPD}
/nfstmp2/merlin/packages/${VER}/agents/mysqlmonitoragent-${VER}-linux-glibc2.3-x86-32bit-update-installer.bin --installdir ${INSTALLDIR} --createBackup 1 --backupdir /data0/merlin/agent/2.2.2.1729/rhel4-x86-32bit/net-qa1/backup_2.3.0.2025 --restartImmediately 0 --mode unattended
diff etc.${UPD}/mysql-monitor-agent.ini etc/mysql-monitor-agent.ini

Suggested fix:
a) remember the settings from installation and re-use them during update (= the default that is shown to the user is what has been selected last time)
or
b) use the current setting from the .ini file as default

Andy Bang writes: 
I think I've seen this in the GUI installer as well -- doing an upgrade it asks you what components to install (because we added the aggregator in 2.3), but the Proxy checkbox was unchecked even though it was previously installed.

Is the installer looking at the "plugins=xxx" parameter in the mysql-monitor-agent.ini file to determine what's installed? If it includes "proxy" (e.g. "plugins=proxy,agent"), then it should assume the proxy is installed and should continue to be activated.

Patch sent to Andy

Andy Bang writes: 
In build 2.3.0.2027.

Carsten Segieth writes: 
OK in 2.3.0.2028