Bug #56877 Patch to fix some problems linking with --as-needed
Submitted: 20 Sep 2010 18:34 Modified: 24 Oct 2010 9:55
Reporter: Hans de Graaff Email Updates:
Status: Not a Bug Impact on me:
None 
Category:MySQL Workbench Severity:S3 (Non-critical)
Version:5.2.28 OS:Any
Assigned to: Alfredo Kojima CPU Architecture:Any
Tags: as-needed, linker

[20 Sep 2010 18:34] Hans de Graaff 
Description:
At Gentoo we currently apply the attached patch to fix problems when linking with the --as-needed linker flag. We originally created this patch for the 5.2.17 release but it seems I never opened a bug for it. Due to the delay I can't recall the exact failure mode, but I believe that in this case compilation went fine, but at runtime the modules could not be loaded on demand.

How to repeat:
Compile and link the application with --as-needed: http://www.gentoo.org/proj/en/qa/asneeded.xml

Suggested fix:
See attached patch.
[20 Sep 2010 18:35] Hans de Graaff 
as-needed-modules.patch

Attachment: mysql-workbench-5.2.17-as-needed-modules.patch (application/octet-stream, text), 817 bytes.
[20 Sep 2010 18:38] Hans de Graaff 
Note that this patch just fixes problems I happened to encounter, but I don't use all of the functionality so there may be other modules suffering from the same problems. It might be a good idea to check the Makefile.am files and add LIBADD definitions everywhere where similar CFLAGS definitions are added to INCLUDES.
[24 Sep 2010 0:33] Alfredo Kojima 
Hi

Please provide details about what are the problems encountered.

I cannot apply a patch that fixes a problem in an unsupported distribution, while risking introducing new bugs in others that have no problems currently.

I am not familiar with "--as-needed", but reading the page you linked it sounds like it could break the automatic dependency detection in rpm and deb based distributions.
[24 Sep 2010 0:40] Alfredo Kojima 
Seems I misunderstood the request. Should have looked at the patch 1st :)

Anyway, the patch fixes stuff in modules that are no longer built in more recent versions of WB CE:
wb.validation and wb.mysql.validation are Standard Edition specific modules and they're empty in the Community Edition anyway, so we're no longer building them in it.

So, I'm closing this issue with Not a Bug. But thanks for reporting!
[24 Oct 2010 9:55] Hans de Graaff 
Thanks for the explanation, I've dropped the patch in Gentoo.