MySQL Bugs: #56682: meb.incremental

Bug #56682	meb.incremental_inb fails
Submitted:	9 Sep 2010 10:46	Modified:	15 Sep 2010 16:36
Reporter:	Ingo Strüwing	Email Updates:
Status:	Can't repeat	Impact on me:	None
Category:	MySQL Enterprise Backup	Severity:	S2 (Serious)
Version:	3.5.next revno 228	OS:	Any
Assigned to:	Ritheesh Vedire	CPU Architecture:	Any

Description:
meb.incremental_inb fails:

meb.incremental_inb 'innodb_plugin'      [ fail ]
        Test ended at 2010-09-09 12:32:23

CURRENT_TEST: meb.incremental_inb
mysqltest: In included file "./suite/meb/include/incremental.inc": At line 223: command "$INNOBACKUP --port=$MASTER_MYPORT --user=root --no-timestamp --incremental --lsn $BACKUP_LSN1 $SERVER_CNF $BACKUP2 >$LOGDIR/backup-inc1.log 2>&1" failed

$LOGDIR/backup-inc1.log contains:
mysqlbackup: Using ibbackup version 3.5.next MySQL Enterprise Backup 3.5.1
mysqlbackup: --incremental option was given, but ibbackup is too old to support it, You must upgrade to ibbackup  v3.5 or later in order to use --incremental option

How to repeat:
Build meb 3.5.next revno 228
Run meb.incremental_inb on mysql-5.1-meb.

Suggested fix:
In is_ibbackup_compatible()
    if (compare_versions(ver, "3.5") == -1)
instead of
    if (compare_versions(ver, "3.5.0") == -1)
helps.
The problem is that at end of compare_versions(), the remaining strings are "next" versus "0". Since 'n' is not a number, the version with '0' is taken as later. So, 3.5.next is equivalent to 3.5, which seems older than 3.5.0.
Requiring just 3.5 as the error message says, makes this comparison behave as wanted.

This problem doesn't exist anymore, as the version of ibbackup has been changed to
3.5.2.
The following is the output from meb-3.5.next (revno 232)

rith@rith-laptop:~/Work/MySQL/meb-3.5.next/meb-ibbackup/back$ ./ibbackup --version
ibbackup version 3.5.2 MySQL Enterprise Backup version 3.5.1
Copyright (c) 2002, 2010, Oracle and/or its affiliates.

Forgot to assign this bug to myself. Assigning it now.