Bug #56610 Replace the toolname "innobackup" with "mysqlbackup"

• Submitted: 7 Sep 2010 10:50
• Modified: 20 Oct 2010 8:59
• Reporter: Satya B
• Status: Closed
• Category: MySQL Enterprise Backup
• Severity: S3 (Non-critical)
• Version: 3.5
• OS: Any
• Assigned to: Satya B
• CPU Architecture: Any
• Tags: innobackup C, meb

[7 Sep 2010 10:50] Satya B

Description:
The new innobackup C should be called 'mysqlbackup'

The entire code was written with 'innobackup' as the tool name in mind.

Replace all occurrences of 'innobackup' with 'mysqlbackup'

How to repeat:
No need to repeat

Suggested fix:
See in description

[7 Sep 2010 11:06] Satya B

This patch changes all occurrences of 'innobackup' with 'mysqlbackup' &
INNOBACKUP with 'MYSQLBACKUP'.

This way we have uniform tool name 'mysqlbackup' across the code base.

The only places where 'innobackup' can be found after applying this patch is the
file names. innobackup_mysql.h , innobackup_mysql.h innobackup_log.c, innobackup_util.c , innobackup_util.h.

Ideally this can also be changed but a decision is needed to do this change.

[8 Sep 2010 7:42] Satya B

Adding Thava and Ritheesh as reviewers

[8 Sep 2010 9:31] Thava Alagu

Reviewed and it is good to push.

[8 Sep 2010 12:23] Satya B

revision-id: [e-mail]-20100908074010-b03ci2d2pis2153a in meb-3.5.next

[18 Oct 2010 18:46] John Russell

Still need to fix 2 occurrences of "innobackup" in the help text for the ibbackup command.
Also, the help text still refers to innoback as Linux/Unix-only, which is no longer true.
Need to fix in the code first, then the updated help text will get into the doc as part of the sample output periodically supplied by Pekka.

[19 Oct 2010 10:06] Satya B

well, this bug is for mysqlbackup code only. 

We should replace the innobackup with mysqlbackup in 'ibbackup' code too.

[19 Oct 2010 10:09] Satya B

Bug#57526 for wrong help text in windows

[20 Oct 2010 8:59] Satya B

meb-innobackup-c/src/innobackup.c
=== modified file 'meb-ibbackup/back/back0back.c'
--- a/meb-ibbackup/back/back0back.c	2010-10-13 11:23:49 +0000
+++ b/meb-ibbackup/back/back0back.c	2010-10-20 08:51:19 +0000
@@ -7155,7 +7155,7 @@ static const char *help_text = "Usage:\n
 "The backup program does NOT make a backup of the .frm files of the tables,\n"
 "and it does not make backups of MyISAM tables. To back up these items, either:\n"
 "\n"
-"- Use the innobackup script (available for Linux and Unix systems only).\n"
+"- Use the mysqlbackup program.\n"
 "\n"
 "- Make backups of the .frm files with the Unix 'tar' or the Windows WinZip\n"
 "or an equivalent tool both BEFORE and AFTER ibbackup finishes its work,\n"

rev 249 in meb-3.5.next