MySQL Bugs: #56394: backup_type col in history logs does not indicate Incremental backup properly

Bug #56394	backup_type col in history logs does not indicate Incremental backup properly
Submitted:	31 Aug 2010 4:28	Modified:	31 Aug 2010 22:32
Reporter:	Hema Sridharan	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Backup	Severity:	S3 (Non-critical)
Version:	MEB3.5	OS:	Any
Assigned to:	Satya B	CPU Architecture:	Any

Description:
Execute incremental backup using innobackup tool. Now check the backup_history logs for type of backup performed. This shows as "INCREMENTADIRECTORY" instead of "INCREMENTAL".

How to repeat:
Please run the attached test in mysql-5.1-meb tree using latest innobackup C repo.

We get the following result.

# TEST 1: Test backup_type
# The expected result for this is "FULL"
SELECT backup_type FROM mysql.backup_history;
backup_type
FULL
INCREMENTADIRECTORY

Suggested fix:
The backup_type should be shown as INCREMENTAL as per design.

I have done the following steps.

I am using the innobackup and ibbackup meb-3.5.next
then ./mtr meb.incremental_inb.

vi var/log/meb.incremental_inb/mysqld.1/data/mysql/backup_history.CSV

The contents:
=============

12832364020783750,"/home/satya/WORK/meb-3.5.next/meb-innobackup-c/innobackup --ibbackup=/home/satya/WORK/meb-3.5.next/meb-ibbackup/back/ibbackup --port=13000 --user=root --no-timestamp /home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/my.cnf /home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/tmp/backup1 ","2010-08-31 09:33:22","2010-08-31 09:33:25",-1,"BINLOG-DISABLED",1,"MEMORY:MyISAM:InnoDB:CSV:","ibdata1:10M;ibdata2:10M:autoextend","Antelope",36864,182174,37356,"FULL","DIRECTORY","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","3","5M","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/tmp/backup1",0.000,"SUCCESS","NO_ERROR",0
12832364198863370,"/home/satya/WORK/meb-3.5.next/meb-innobackup-c/innobackup --ibbackup=/home/satya/WORK/meb-3.5.next/meb-ibbackup/back/ibbackup --port=13000 --user=root --no-timestamp --incremental --lsn 37356 /home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/my.cnf /home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/tmp/backup2 ","2010-08-31 09:33:39","2010-08-31 09:33:43",-1,"BINLOG-DISABLED",1,"MEMORY:MyISAM:InnoDB:CSV:","ibdata1:10M;ibdata2:10M:autoextend","Antelope",37357,311799,227424,"INCREMENTAL","DIRECTORY","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","3","5M","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/tmp/backup2",1.000,"SUCCESS","NO_ERROR",0
12832364392650310,"/home/satya/WORK/meb-3.5.next/meb-innobackup-c/innobackup --ibbackup=/home/satya/WORK/meb-3.5.next/meb-ibbackup/back/ibbackup --port=13000 --user=root --no-timestamp --incremental --lsn 311799 /home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/my.cnf /home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/tmp/backup3 ","2010-08-31 09:33:59","2010-08-31 09:34:01",-1,"BINLOG-DISABLED",1,"MEMORY:MyISAM:InnoDB:CSV:","ibdata1:10M;ibdata2:10M:autoextend","Antelope",311800,446153,416238,"INCREMENTAL","DIRECTORY","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/mysqld.1/data","3","5M","/home/satya/WORK/mysql-5.1-meb-wl-5319/mysql-test/var/tmp/backup3",0.000,"SUCCESS","NO_ERROR",0

There is only INCREMENTAL.

May be I am missing something?

This issue is now fixed with the latest patch. Hence closing the bug.