Bug #56385 Add possibility to flush all logs except error one (flush_log_ignore_error)

Description:
Currently when user run FLUSH LOGS all logs including error log are flushed. This is not convenient if you want to have all information about errors recorded.

How to repeat:
Run FLUSH LOGS 2 times and get 0-bytes error log with all information about errors removed.

Suggested fix:
See file with patch attached. One should have option flush_log_ignore_error_log specified in the configuration file to use this feature.

Patch

Attachment: diff_flush_logs_ignore_error_log.txt (text/plain), 6.17 KiB.

Patch created for 5.1.50, but successfully compiles and works with 5.1 development sources.

Does not fix for Bug#29751 "Do not rename the error log at FLUSH LOGS" implement exactly what you want?

From what I can understand that removes the functionality completely, so whoever wants to flush error logs with flush logs can't, something which has been there for a while. The fix I'm proposing adds a variable to enable or disable flushing error logs using flush logs.

Hmm, I actually expect that other patch to be pushed sooner or later, as it is in a "patch approved" status.  flush_log_ignore_error would not make much sense then, right?

It is not important for me which patch goes in as long as the error log is not cycled. I just didn't want to remove any previous functionality for whoever is using it. I am not a fan of taking away things which were there before but if Oracle is cool with that I don't mind :)

See also BUG#14104, which allowed user to selectively flush logs.

I wrote a patch for bug 14104 which allows the user to specify which logs they want to flush.

I propose that we close this as a duplicate of bug #29751 since that patch will make this path unnecessary. Does everyone agree with that?

Duplicate of BUG#29751 and BUG#14104.