Bug #56234 The new innobackup_log.cc code makes all the tests fail in meb suite.
Submitted: 24 Aug 2010 21:47 Modified: 6 Sep 2010 14:07
Reporter: Hema Sridharan Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Enterprise Backup Severity:S2 (Serious)
Version:innobackup 1.7 OS:Linux (64 bit)
Assigned to: Satya B CPU Architecture:Any

[24 Aug 2010 21:47] Hema Sridharan
Description:
The new patch created for WL#5495 (Table based logging for innobackup) generates innobackup table based logs. When this patch is applied, it makes all the innobackup tests fail in meb suite (mysql-5.1-meb tree).

How to repeat:
* Pull new innobackup C code from bk-internal.mysql.com/bzrroot/meb/innobackup-c-review
* Compile using cmake and make to get the innobackup executable (Check the README instructions)
* Now apply the new patch that will generate innobackup logs (This patch can be obtained from commits-mysql-enterprise-backup email list)
* Export the new innobackup to $INNOBACKUP.
* Execute the innobackup tests from mysql-5.1-meb tree. For example

./mtr --suite=meb integrity_innobackup

==============================================================================

TEST                                      RESULT   TIME (ms)
------------------------------------------------------------

worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009
meb.integrity_innobackup                 [ fail ]
        Test ended at 2010-08-24 23:34:17

CURRENT_TEST: meb.integrity_innobackup
sh: line 1: 26271 Segmentation fault      /export/home/tmp/MEB/inno-repo/inbtesting/innobackup_172/innobackup --ibbackup=/home/hs221732/hotbackup/3.5/back/ibbackup --copy-back /export/home2/tmp/MEB/mysql-5.1-meb-5321-push/mysql-test/var/my.cnf /export/home2/tmp/MEB/mysql-5.1-meb-5321-push/mysql-test/var/tmp/meb_bup_dir >/export/home2/tmp/MEB/mysql-5.1-meb-5321-push/mysql-test/var/tmp/cpback.log 2>&1
mysqltest: At line 110: command "$INNOBACKUP --copy-back $SERVER_CNF $BACKUP_TARGET_DIR > $CPBACK_LOG 2>&1" failed

Also please check the innobackup --copy-back logs attached.

Suggested fix:
Need to fix the issue soon as we don't want all the tests to be failing.
[25 Aug 2010 4:19] Satya B
Hema,

Can you please attach the copy-back log? I have few things to ask.

1. Are you using the test patch? or the patch which is submitted for code review

2. bzr revno output?

3. please do bzr diff> 5495.patch in your branch and attach it here.

I have seen this during my initial testing and it is fixed.
[25 Aug 2010 4:39] Hema Sridharan
Please take a look at the attached file for copy-back logs

Attachment: cpback.log (application/octet-stream, text), 2.06 KiB.

[26 Aug 2010 12:54] Satya B
Hema,
Please test the patch I've sent you and if it works, please close the bug.

Changing the state to 'patch queued' although I am going to fix in the WL.
[6 Sep 2010 14:07] Satya B
fixed in meb-3.5.next/meb-innobackup-c