Bug #56117 ha_ndbcluster_tables.h included by mysqldump but not used

• Submitted: 19 Aug 2010 12:09
• Modified: 3 Oct 2010 1:22
• Reporter: Magnus Blåudd
• Status: Closed
• Category: MySQL Server
• Severity: S3 (Non-critical)
• Version: 5.5.6-m3, 5.1
• OS: Any
• Assigned to: Magnus Blåudd
• CPU Architecture: Any

[19 Aug 2010 12:09] Magnus Blåudd

Description:
mysqldump includes the file ha_ndbcluster_tables.h but it dot not use anything from it. The include can be removed.

How to repeat:
Comment out the line including the mentiond file and compile. It works fine.

Suggested fix:
Remove the include line.

msvensson@pilot:~/mysql/5.5$ bzr diff
=== modified file 'client/mysqldump.c'
--- client/mysqldump.c	2010-07-15 11:16:06 +0000
+++ client/mysqldump.c	2010-08-19 12:06:04 +0000
@@ -50,7 +50,6 @@
 #include "mysql.h"
 #include "mysql_version.h"
 #include "mysqld_error.h"
-#include "../sql/ha_ndbcluster_tables.h"

[21 Aug 2010 10:02] Sveta Smirnova

Thank you for the report.

Verified as described.

[30 Aug 2010 12:33] Magnus Blåudd

Pushed to 5.5-bugfixing, trunk-bugfixing and next-mr-bugfixing

[30 Aug 2010 12:46] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.47-ndb-7.0.19 (revid:[e-mail]-20100830121448-grzbf4451bu6vndr) (version source revid:[e-mail]-20100830121448-grzbf4451bu6vndr) (merge vers: 5.1.47-ndb-7.0.19) (pib:21)

[30 Aug 2010 18:28] Paul DuBois

Code cleanup, no user impact. No changelog entry needed.

[31 Aug 2010 11:38] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/117211

[31 Aug 2010 13:22] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/117240

[2 Oct 2010 18:12] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:[e-mail]-20101002180948-852x1cuv7c6i85ea) (version source revid:[e-mail]-20101002180857-an32jpuwzemsp4f2) (merge vers: 5.6.1-m4) (pib:21)

[2 Oct 2010 18:14] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20101002181053-6iotvl26uurcoryp) (version source revid:[e-mail]-20101002180917-h0n62akupm3z20nt) (pib:21)

[2 Oct 2010 18:16] Bugs System

Pushed into mysql-5.5 5.5.7-rc (revid:[e-mail]-20101002180831-590ka2tuit9qoxbb) (version source revid:[e-mail]-20101002180831-590ka2tuit9qoxbb) (merge vers: 5.5.7-rc) (pib:21)