MySQL Bugs: #56000: Add table: 1] incorrect amount of (different) errors on retry & 2] cancel button

Bug #56000	Add table: 1] incorrect amount of (different) errors on retry & 2] cancel button
Submitted:	16 Aug 2010 8:42	Modified:	16 Sep 2010 16:02
Reporter:	Roel Van de Paar	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench: SQL Editor	Severity:	S3 (Non-critical)
Version:	5.2.25, 5.2.26	OS:	Any
Assigned to:	Sergei Tkachenko	CPU Architecture:	Any

Description:
In the add table view: 

1] An incorrect amount of (and different) errors are given when retrying a failing transaction 

2] Removal of cancel button as it serves no purpose (there is no "cancel" functionality)

How to repeat:
See video

1) Since change script can consist of multiple statements, it's possible to lose data if script fails in the middle. Failback script is called to resolve this issue by running initial object's DDL. Duplicated error, that was reported, comes from the failback script which in this case is almost similar to change script. I added clarifying message in between 2 error messages, saying:
ERROR: Error when running failback script. Details follow.

2) Added disabling of 'Finish' or 'Cancel' button depending on the result of applying changes to database.

fix confirmed in repository

An entry has been added to the 5.2.8 changelog:

There were two problems in the new_table dialog of the SQL Editor:

When Apply was clicked, in the Apply SQL Script to Database dialog, if Apply SQL was clicked, the SQL would be applied without error. However, if the Back button was clicked and the Apply SQL button clicked again, an error would be generated. If this process was repeated, each time a slightly different error would be added to the list of errors displayed.

The Cancel and Finish buttons appeared to have the same functionality, and simply returned the user to the new_table dialog.