MySQL Bugs: #55295: Solaris agents should report swap as swap -l as opposed to swap -s

Bug #55295	Solaris agents should report swap as swap -l as opposed to swap -s
Submitted:	15 Jul 2010 16:13	Modified:	28 Jan 2011 23:35
Reporter:	Shannon Wade	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Agent	Severity:	S4 (Feature request)
Version:		OS:	Solaris
Assigned to:	Jan Kneschke	CPU Architecture:	Any

Description:

"The current Solaris implementation of sigar_swap_get uses swapctl(SC_AINFO, ...), similar to the output of /usr/sbin/swap -s and older versions of top. More recent versions of top use swapctl(SC_LIST, ...), using the same values seen in /usr/sbin/swap -l"

The effect of this is the agents report swap including physical memory  which is different than other platforms.

Please see hyperic discussion here:

http://jira.hyperic.com/browse/SIGAR-215?page=com.atlassian.jira.plugin.system.issuetabpan...

It looks as if newer sigar versions (1.6) report swap similiar to swap -l output which would have the intended effect. 

How to repeat:
Try to determine on solaris swap area on disk free and total.

Suggested fix:
Not sure if this could be configurable on how it's displayed. Some users who know Solaris and expect the traditional swap meaning may not welcome this change, whereas others will expect the same swap reporting behavior across different platforms.

Mark Leith writes: 
We are using the latest SIGAR versions, which does the SC_LIST version at the moment anyway. 

Solaris users do indeed expect Swap to show both physical and virtual memory, and this is what MEM is currently showing, so we can not reproduce this.

Jan Kneschke writes: 
merged the patch from the git tree over to our internal tree:

{noformat}
revno: 2545
fixes bug(s): http://bugs.mysql.com/55295
committer: jan@mysql.com
branch nick: sigar
timestamp: Thu 2010-07-29 15:42:10 +0200
message:
  merged over swapctl from sigar's trunk (fixes #55295/EM-4676)
  
     (SIGAR-215) use swapctl SC_LIST for Solaris swap_get impl
modified:
  src/os/solaris/solaris_sigar.c
{noformat}

Andy Bang writes: 
In build 2.2.3.1734.

Carsten Segieth writes: 
tested OK in 2.2.3.1755

Added to change log for 2.2.3:

The reported swap space on Solaris included physical memory, which
was inconsistent with modern top output and the reporting on other
platforms. Now the swap space is reported consistently, using the
same values as reported by the command swap -l.