MySQL Bugs: #55096: agent-master-uuid-discovery docs should be changed

Bug #55096	agent-master-uuid-discovery docs should be changed
Submitted:	8 Jul 2010 18:48	Modified:	20 Jul 2010 13:24
Reporter:	Andrii Nikitin	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Documentation	Severity:	S3 (Non-critical)
Version:	2.2.1.1717	OS:	Any
Assigned to:	MC Brown	CPU Architecture:	Any

Description:
1. With both values 1 and 0
agent-master-uuid-discover still tries to connect to master using master.info

2010-07-08 20:18:26: (critical) job_collect_mysql.c:568: [mysql->127.0.0.1:34095] (master-uuid) mysql_real_query(SELECT value FROM mysql.inventory WHERE name='uuid') on the slave's master failed: SELECT command denied to user 'repl'@'localhost' for table 'inventory' (1142)
Check that mysql.inventory exists on this slave's master, if it does, run on the master:
GRANT SELECT ON mysql.inventory TO 'repl'@'%';

2. Current description in is Docs probably wrong:
https://enterprise.mysql.com/docs/monitor/2.2/en/mem-program-reference.html#option_mysql-m...

"
Setting this option to true will prevent the agent from accessing the master.info and using the UUID obtained from the replication master
"

But logically this behavior should be if 
agent-master-uuid-discovery=0

related to bug #50604

How to repeat:
1. Setup replication with user which doesn't have access to mysql.inventory

2. Start agent two times with both 
agent-master-uuid-discovery=0
and
agent-master-uuid-discovery=1

Following error is printed in agent log both times:
(critical) job_collect_mysql.c:568: [mysql->127.0.0.1:34095] mysql_real_query(SELECT value FROM mysql.inventory WHERE name='uuid') on the slave's master failed

Suggested fix:
1. agent shouldn't connect to master when agent-master-uuid-discovery=0
2. docs should describe this parameter properly (i.e. opposite to current description).

Initial problem in behavior because of spelling error in configuration file.

Docs still should be changed to opposite:
Instead of
"Setting this option to true will prevent the agent from accessing the master.info and using the UUID obtained from the replication master"
should be
"Setting this option to false will prevent the agent from accessing the master.info and using the UUID obtained from the replication master"

Michael Schuster writes: 
also note: the documented default is wrong, it should be "true" (so that there's no change in behaviour if this option is not specified)

Documentation has been updated as requested.