MySQL Bugs: #54124: Various issues in WorkBench RC

Bug #54124	Various issues in WorkBench RC
Submitted:	1 Jun 2010 5:22	Modified:	27 Sep 2010 14:22
Reporter:	Roel Van de Paar	Email Updates:
Status:	Can't repeat	Impact on me:	None
Category:	MySQL Workbench: SQL Editor	Severity:	S2 (Serious)
Version:	5.2.21 OSS RC	OS:	Any
Assigned to:	Alexander Musienko	CPU Architecture:	Any

Description:
Various items. Easier to show in a video. See attached video.

- Crash (same crash, seen in different use cases, easy reproducible)
- Does not validate input correctly (wants to execute invalid syntax, does not warn users for simple errors)
- Does not handle input correctly (select "PK" and it's unticked, unable to add additional rows "lock")
- Makes user entries useless in a certain use case (add table without columns, then add columns > unable to apply)
- Wipes away user entries in a certain use case (create index but do not select any columns: no validation and entered data is wiped away)

How to repeat:
See video.

2nd case is a duplicate of the bug #53887.

Great idea to demonstrate the issues by videos. Very helpfull indeed.

However these 4 issues should have been 4 different reports so we can assign them to the appropriate developers.

Issue one is fixed in repository.

Fix for part 3 is pushed. Part 4 is already fixed in the code repository.

fixes confirmed in repository.

the "WB creates invalid code" parts though are not yet covered in Workbench 5.2 but we already have live-validations like this on our list for future versions.

WB Team, I am impressed with your ability to handle/fix bugs. Makes me want to test more!

An entry has been added to the 5.2.24 changelog:

In the SQL Editor, if a space was typed into the SQL Query tab, an external tab, such as the Overview tab or Output tab selected, and then File, Close Tab selected, MySQL Workbench crashed.

Further, the Add Table dialog had numerous issues, including inability to select PK and other checkboxes, failure to validate input, inability to apply changes, and deletion of user data in certain cases.

Can't repeat "No changes to object were detected" here. Is there any additional condition that triggers error?