MySQL Bugs: #53854: agent connection doesn't include password anymore, messages could be improved

Bug #53854	agent connection doesn't include password anymore, messages could be improved
Submitted:	20 May 2010 12:38	Modified:	9 Jan 2015 14:43
Reporter:	Roger David Nay	Email Updates:
Status:	Won't fix	Impact on me:	None
Category:	MySQL Enterprise Monitor: Agent	Severity:	S3 (Non-critical)
Version:	2.2	OS:	Any
Assigned to:	Assigned Account	CPU Architecture:	Any

Description:
Previous agent versions included the user and password info.

2010-05-19 17:15:48: (critical) network-io.c:310: successfully reconnected to dashboard at http://agent:agag3301@localhost:18080/heartbeat

The new version strips it out the password information, so now it looks like it is missing.

2010-05-20 14:27:06: (critical) network-io.c:312: successfully reconnected to dashboard at http://agent@localhost:18080/heartbeat

How to repeat:
N/A

Suggested fix:
Add <hidden> to replace the password information:

'successfully reconnected using user and password to dashboard at http://agent:<hidden>@localhost:18080/heartbeat'

This appears to work without breaking the url:

'successfully reconnected to dashboard at http://agent:(password)@localhost:18080/heartbeat'

or maybe a different message:

'successfully reconnected using user and password to dashboard at http://localhost:18080/heartbeat'

Mark Matthews writes: 
We changed the log message on purpose as the fix for Bug#53199. This change is on purpose, and as-intended.

Mark Matthews writes: 
Re-opening, because the underlying issue is that we still build the URL to include the user/pass, even though the configuration file can now have them broken out. We should be using CURLOPT_USERPWD or CURLOPT_USERNAME/CURLOPT_PASSWORD.