Bug #53644 InnoDB thinks that /*/ starts and ends a comment

• Submitted: 14 May 2010 12:15
• Modified: 14 Oct 2010 15:21
• Reporter: Marko Mäkelä
• Status: Closed
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: 4.0, 4.1, 5.0, 5.1
• OS: Any
• Assigned to: John Russell
• CPU Architecture: Any
• Tags: innodb FOREIGN KEY /*/ parser

[14 May 2010 12:15] Marko Mäkelä

Description:
I noticed (and fixed) this while working on the Bug #48024 fix. The InnoDB FOREIGN KEY constraint parser treats the string /*/ as a complete comment. It is merely a start of a comment. /**/ is the shortest possible comment of that form.

How to repeat:
CREATE TABLE bug48024(a int PRIMARY KEY,b int NOT NULL,KEY(b)) ENGINE=InnoDB;
CREATE TABLE bug48024_b(b int PRIMARY KEY) ENGINE=InnoDB;
ALTER TABLE bug48024 /*/ADD CONSTRAINT FOREIGN KEY(c) REFERENCES(a),/*/
ADD CONSTRAINT FOREIGN KEY(b) REFERENCES bug48024_b(b);

InnoDB will complain about the constraint in the comment.

Suggested fix:
On /*, advance the position by 2 characters.

[14 May 2010 13:03] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108326

[14 May 2010 13:03] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108327

[14 May 2010 13:08] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108328

[14 May 2010 13:08] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108329

[14 May 2010 13:11] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108331

[14 May 2010 13:11] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108333

[31 May 2010 8:29] Bugs System

Pushed into 5.1.48 (revid:[e-mail]-20100531082307-9x08gg1g7zybx2jy) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:16)

[17 Jun 2010 6:12] Bugs System

Pushed into 5.5.5-m3 (revid:[e-mail]-20100615145247-8bj0vmuqlotbqsn9) (version source revid:[e-mail]-20100514130815-ym7j7cfu88ro6km4) (merge vers: 5.1.48) (pib:16)

[17 Jun 2010 6:15] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100615150216-cubqoyn1fj9b6a2p) (version source revid:[e-mail]-20100514130815-ym7j7cfu88ro6km4) (pib:16)

[30 Jun 2010 21:07] John Russell

Added to change log:

InnoDB mistakenly considered the sequence <literal>/*/</literal> to be an open/close comment sequence.

[14 Oct 2010 8:29] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 8:45] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 8:59] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 15:21] Jon Stephens

Already documented in the 5.1.48 changelog; no new changelog entries required. setting back to Closed state.