Bug #53427 restart_mysqld.inc does not clean up created files
Submitted: 5 May 2010 8:33 Modified: 5 Jun 2010 10:02
Reporter: Magnus Blåudd Email Updates:
Status: No Feedback Impact on me:
None 
Category:Tests: Server Severity:S3 (Non-critical)
Version:5.1.47 OS:Any
Assigned to: CPU Architecture:Any

[5 May 2010 8:33] Magnus Blåudd
Description:
The include file mysqld_restart.inc used for events_restart.test does not clean up after itself and thus it may fail because a file it want to write already exists.

How to repeat:
main.events_restart                      w6 [ fail ]
        Test ended at 2010-05-04 18:23:05

CURRENT_TEST: main.events_restart
mysqltest: In included file ".\include\restart_mysqld.inc": At line 8: File already exist: 'g:/var-test-5/6/tmp/mysqld.1.expect'

Suggested fix:
Remove the .expect file before and after include file is finished.
[5 May 2010 8:38] Magnus Blåudd
=== modified file 'mysql-test/include/restart_mysqld.inc'
--- mysql-test/include/restart_mysqld.inc	2008-12-25 09:53:24 +0000
+++ mysql-test/include/restart_mysqld.inc	2010-05-05 08:37:53 +0000
@@ -1,3 +1,4 @@
+--remove_file $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
 
 # Write file to make mysql-test-run.pl expect the "crash", but don't start
 # it until it's told to
@@ -23,3 +24,4 @@ EOF
 # Turn off reconnect again
 --disable_reconnect
 
+--remove_file $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
[5 May 2010 8:44] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/107420
[5 May 2010 9:25] Magnus Blåudd
Seems like this fails becuse the mtr's automatic cleanup of $MYSQLTEST_VARDIR/tmp fails with error:

worker[6] mysql-test-run: WARNING: unlink(g:/var-test-5/6/tmp/mysqld.1.expect) failed: Permission denied
[5 May 2010 10:02] Sveta Smirnova
Thank you for the report.

> Seems like this fails becuse the mtr's automatic cleanup of $MYSQLTEST_VARDIR/tmp fails
with error:

How to start MTR so it fails with such error: I can not repeat failure due to include/restart_mysqld.inc
[5 Jun 2010 23:00] Bugs System
No feedback was provided for this bug for over a month, so it is
being suspended automatically. If you are able to provide the
information that was originally requested, please do so and change
the status of the bug back to "Open".