Bug #53316 mysql.h doesn't include winsock2.h
Submitted: 30 Apr 2010 14:07 Modified: 15 Jun 2010 16:27
Reporter: Olaf van der Spek (Basic Quality Contributor) Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Server: C API (client library) Severity:S4 (Feature request)
Version:5.1, 5.5 OS:Microsoft Windows
Assigned to: CPU Architecture:Any
Tags: qc
Triage: Needs Triage: D5 (Feature request)

[30 Apr 2010 14:07] Olaf van der Spek
Description:
mysql.h:
#ifdef __LCC__
#include <winsock2.h>				/* For windows */
#endif

Could winsock2.h be included on Windows when __LCC__ isn't defined as well?
I'm using Visual C++ 2010.
I know I could include winsock2.h myself before including mysql.h, but I don't see why this can't be fixed the proper way.

How to repeat:
#include <mysql/mysql.h>

int main()
{
  return 0;
}
[30 Apr 2010 14:07] Olaf van der Spek
-
[15 Jun 2010 15:54] Valeriy Kravchuk
See bug #438 also...
[15 Jun 2010 15:57] Valeriy Kravchuk
Verified by code review. Not sure if we still need it this way... Workaround is to include other headers before mysql.h :)
[15 Jun 2010 16:27] Olaf van der Spek
I like solutions, not work arounds. ;)