Bug #52874 test == in ext/ctemplate/ctemplate-src/configure.ac
Submitted: 15 Apr 2010 23:02 Modified: 21 Apr 2010 16:39
Reporter: Twang Li Email Updates:
Status: Won't fix Impact on me:
Category:MySQL Workbench Severity:S2 (Serious)
Version:5.2.18 OS:Other (NetBSD)
Assigned to: CPU Architecture:Any
Tags: configure, Contribution, test

[15 Apr 2010 23:02] Twang Li
test ==

How to repeat:
bmake configure

Suggested fix:

--- ext/ctemplate/ctemplate-src/configure.ac.orig	2010-04-13 03:42:08.000000000 +0000
+++ ext/ctemplate/ctemplate-src/configure.ac
@@ -87,16 +87,16 @@ AC_SUBST(ac_cv_cxx_hash_map)
-if test "$ac_cv___attribute__" == "yes"; then
+if test "$ac_cv___attribute__" = "yes"; then
    AC_SUBST(ac_google_attribute, 1)
    AC_SUBST(ac_google_attribute, 0)
-if test "$ac_cv_type_u_int64_t" == "yes"; then
+if test "$ac_cv_type_u_int64_t" = "yes"; then
    AC_SUBST(ac_cv_uint64, u_int64_t)
-elif test "$ac_cv_type_uint64_t" == "yes"; then
+elif test "$ac_cv_type_uint64_t" = "yes"; then
    AC_SUBST(ac_cv_uint64, uint64_t)
-elif test "$ac_cv_type___int64" == "yes"; then
+elif test "$ac_cv_type___int64" = "yes"; then
    AC_SUBST(ac_cv_uint64, unsigned __int64)
    AC_SUBST(ac_cv_uint64, unsigned long long)   # best we can do
[19 Apr 2010 6:57] Susanne Ebrecht
Many thanks for writing a bug report.

Verified as described by source code analysis.
[20 Apr 2010 13:15] Alfredo Kojima

Your patch is for the ctemplate config files, we don't maintain that software and only bundle it for
convenience. In addition we'd lose any such changes whenever we upgrade ctemplate (or when we unbundle it at some point). So I think the best is for you to pre-install ctemplate and configure 
Workbench with the --with-system-ctemplate configure flag, which will make it use a previously 
installed version of ctemplate.

Because of that I'll mark the bug as Won't Fix
[21 Apr 2010 16:39] Twang Li
NetBSD doesn´t have a system ctemplate, but i imported it into pkgsrc-wip yesterday to use with the build. I´d suggest not bundling this with your distribution, as it seems there´s newer versions of ctemplate. Since you´re also not bundling the other packages from the requirements list, why this one? It could make for a slightly slimmer distribution.