Bug #52814 InnoDB: switch to new ha_data interface

• Submitted: 14 Apr 2010 10:06
• Modified: 18 Oct 2010 19:35
• Reporter: Sergey Vojtovich
• Status: Closed
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: 5.1, plugin 1.0.7
• OS: Any
• Assigned to: Jimmy Yang
• CPU Architecture: Any

[14 Apr 2010 10:06] Sergey Vojtovich

Description:
This is a follow-up to BUG#39053 - "UNISTALL PLUGIN does not allow the storage engine to cleanup open connections".

Fix for BUG#39053 contains server side framework fix, but there is still some work to do on storage engine side. If storage engine requires server to close all connections before shutting down an engine, an engine must switch to new ha_data interface. That is use thd_{set|get}_ha_data() instead of thd_ha_data().

For details see  http://lists.mysql.com/commits/105618

How to repeat:
By code analysis for ha_innodb.cc. InnoDB uses thd_ha_data(), instead of thd_{set|get}_ha_data().

Suggested fix:
Switch from thd_ha_data() to thd_{set|get}_ha_data().

[14 Apr 2010 18:57] Sveta Smirnova

Thank you for the report.

Verified as described.

[19 Jul 2010 14:36] Bugs System

Pushed into 5.1.49 (revid:[e-mail]-20100719143034-omcma40sblwmay3x) (version source revid:[e-mail]-20100704071244-3lo4okzels3kvy1p) (merge vers: 5.1.49) (pib:16)

[23 Jul 2010 12:28] Bugs System

Pushed into mysql-trunk 5.5.6-m3 (revid:[e-mail]-20100723121820-jryu2fuw3pc53q9w) (version source revid:[e-mail]-20100723121820-jryu2fuw3pc53q9w) (merge vers: 5.5.6-m3) (pib:18)

[23 Jul 2010 12:36] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100723121929-90e9zemk3jkr2ocy) (version source revid:[e-mail]-20100723121827-3bsh51m5sj6g4oma) (pib:18)

[28 Jul 2010 0:16] Calvin Sun

No need to document.

[14 Oct 2010 8:39] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)

[14 Oct 2010 8:54] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)

[14 Oct 2010 9:12] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)