Bug #51545 ndbclient used to be 'virtual'. is it faster to just link to the lib?

• Submitted: 26 Feb 2010 9:45
• Modified: 1 Mar 2010 4:22
• Reporter: jack andrews
• Status: Not a Bug
• Category: MySQL Cluster: Cluster (NDB) storage engine
• Severity: S3 (Non-critical)
• Version: mysql-5.1-telco-7.0
• OS: Windows
• Assigned to: jack andrews
• CPU Architecture: Any

[26 Feb 2010 9:45] jack andrews

Description:
ndbclient used to be 'virtual' in cmake - like:

  ADD_LIBRARY(ndbclient dummy.cpp)
  TARGET_LINK_LIBRARIES(ndbclient mysys ndbportlib ndbgeneral ... [etc])

all through CMakeLists.txt (in storage/ndb), there are lots of clients
like:

LINK_LIBRARIES(ndbmgmclient
               ndbmgmapi
               ndblogger
               ndbtrace
               ndbportlib
               ndbgeneral
               dbug
               mysys
               strings)

so: is it faster to just link to the ndbclient like:

LINK_LIBRARIES(ndbmgmclient ndbclient)

?

How to repeat:
...

Suggested fix:
time how long it takes to build a selection of clients; modify CMakeLists.txt as suggested; time how long it takes...

[1 Mar 2010 4:22] jack andrews

there are too few cases to measure a difference.
best to leave it working as-is.