Bug #51518 Editing a routine - close prompts are inconsistent
Submitted: 25 Feb 2010 17:41 Modified: 21 Apr 2010 14:23
Reporter: Greg Thomas Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Workbench: SQL Editor Severity:S3 (Non-critical)
Version:5.2.16 Revision 5249 OS:Windows
Assigned to: Sergei Tkachenko CPU Architecture:Any

[25 Feb 2010 17:41] Greg Thomas
Description:
If you select the "Alter Routine" option on a stored procedure, there is an inconsistency between the two options you have to close the window.

1. Close using the close window "x" in the top right corner - you're prompted "Apply changes? Yes/No/Cancel". This occurs even if you've not changed the routine.

2. Close using the "Close" button on the bottom right. You're never prompted for a confirmation, even if you have changed the routine.

How to repeat:
1. Right click on a stored procedure, select "Alter Routine".
2. Immediately close the window using the "x" in the top right of the window. Note the "Apply changes?" dialogue - despite the lack of changes.
3. Select "Cancel" to return to the routine. Change the routine in some manner. Click the "Close" button. The editing windows closes immediately, without asking for confirmation.

Suggested fix:
Both the "x" and "Close" buttons should act in the same manner;
1. If the routine has not changed, the window should close without prompting.
2. If the routine has changed, the "Apply changes?" dialogue should be presented.
[25 Feb 2010 18:02] Valeriy Kravchuk
Thank you for the bug report. 

On Mac OS X it is even worse. There is no close prompt in any case and changes are just lost when you close that editing window.
[7 Apr 2010 18:21] Sergei Tkachenko
Fixed missing check for changes when using form buttons. Behavior described by Valeriy should go as a separate bug report with higher priority if the bug is still there and there is no similar reports.
[9 Apr 2010 17:57] Johannes Taxacher
fix confirmed in repository
[21 Apr 2010 14:23] Tony Bedford
An entry was added to the 5.2.18 changelog:

In the Alter Routine dialog of the SQL editor, there was inconsistency between the operation of the close dialog button ('X') on the top right of the window, and the Close button on the bottom right. When using the close dialog button you were prompted to save changes, regardless of whether you actually changed the routine or not. When using the Close button, the user was not prompted, even if the routine had changed.