| Bug #50794 | bug in scripts/make_win_bin_dist in 5.1.42 | ||
|---|---|---|---|
| Submitted: | 1 Feb 2010 15:08 | Modified: | 19 Sep 2011 10:42 |
| Reporter: | Zardosht Kasheff (OCA) | Email Updates: | |
| Status: | Can't repeat | Impact on me: | |
| Category: | MySQL Server: Packaging | Severity: | S3 (Non-critical) |
| Version: | OS: | Windows | |
| Assigned to: | Joerg Bruehe | CPU Architecture: | Any |
[1 Feb 2010 15:08]
Zardosht Kasheff
[26 Mar 2010 21:19]
MySQL Verification Team
Thank you for the bug report.
[5 Jul 2011 12:30]
Joerg Bruehe
Sorry, I cannot find proof of the bug claim. Yes, I note that in "scripts/CMakeLists.txt" (5.1) the various "CONFIGURE_FILE" actions seem to introduce another level of "scripts/" directory. But in checking our Windows release build logs, I don't see any error message about the files in "scripts/", and they are contained in the final packages. Similar, the "cp" in question would fail if the source file were missing, and clearly this does not happen in our release builds. So my conclusion is that the reporter's environment (or usage) is different from ours. The proposed change would break our builds. If it remains an issue for users, I propose this patch: === modified file 'scripts/make_win_bin_dist' --- scripts/make_win_bin_dist 2011-07-03 18:08:47 +0000 +++ scripts/make_win_bin_dist 2011-07-05 12:25:14 +0000 @@ -368,7 +368,14 @@ mkdir -p $DESTDIR/scripts for i in $mysql_scripts do - cp scripts/$i $DESTDIR/scripts/$i + if [ -f scripts/$i ] ; then + cp scripts/$i $DESTDIR/scripts/$i + elif [ -f scripts/scripts/$i ] ; then + cp scripts/scripts/$i $DESTDIR/scripts/$i + else + echo "Mandatory expected file '$i' not found - ABORT" + exit 1 + fi done cp -pR sql/share $DESTDIR/ Note, however, this is not tested, and I will continue with this only if there is a clear indication it is (still) an issue for users.
[5 Aug 2011 23:00]
Bugs System
No feedback was provided for this bug for over a month, so it is being suspended automatically. If you are able to provide the information that was originally requested, please do so and change the status of the bug back to "Open".
[18 Aug 2011 18:03]
Joerg Bruehe
Let's have a second try at getting feedback. If there is none, I will set this bug to "can't repeat", based on my comment of July 5.
[18 Sep 2011 23:00]
Bugs System
No feedback was provided for this bug for over a month, so it is being suspended automatically. If you are able to provide the information that was originally requested, please do so and change the status of the bug back to "Open".
[19 Sep 2011 10:42]
Joerg Bruehe
As announced in my entry of August 18, 2011, I now set this bug to "Can't repeat". Anybody encountering the problem: Plase feel free to report it here, together with details about your environment and your build process. As an alternative, you might try the patch I gave in my entry of July 5, 2011. In this case, please still report if you needed it and whether it worked for you.
