Bug #50792 mtr: remove undocumented support for <test>.sh files
Submitted: 1 Feb 2010 14:17 Modified: 4 Feb 2010 13:25
Reporter: Bjørn Munch Email Updates:
Status: Won't fix Impact on me:
None 
Category:Tools: MTR / mysql-test-run Severity:S3 (Non-critical)
Version:5.1+ OS:Any
Assigned to: Bjørn Munch CPU Architecture:Any

[1 Feb 2010 14:17] Bjørn Munch 
Description:
mtr allows you to have a shell script executed before a server is started by having it stored as t/<testname>-master.sh.  This feature has never been documented, and it's only supported on *nix since it explicitly runs via /bin/sh.  Only a few tests use it and these should be able to use other methods.  This feature should be removed rather than documented.

How to repeat:
N/A

Suggested fix:
Just remove the code, but also need to look at the few places it's used.
[4 Feb 2010 13:25] Bjørn Munch 
No Can Do.

These .sh script may have to be run *before* the server starts, take long_tmpdir as an example.  Therefore, it won't work to put it into the test file.

Perhaps we should instead come up with some way to specify a "pre-test" script in some more platform independent way, either Perl or in the mysqltest language.