Bug #50363 Please add "you have uncommitted changes" warning/confirmation to INSERTs editor

• Submitted: 15 Jan 2010 12:36
• Modified: 24 Jan 2013 22:51
• Reporter: Craig Fowler
• Status: Closed
• Category: MySQL Workbench: Modeling
• Severity: S2 (Serious)
• Version: 5.2.10
• OS: Linux
• Assigned to: Alfredo Kojima
• CPU Architecture: Any
• Tags: inserts, UI, warning

[15 Jan 2010 12:36] Craig Fowler

Description:
Please add a warning/confirmation dialog to the INSERTs editor that prompts the user along the lines of:

"You have uncommitted changes, save them?  Yes/No/Abort" if the INSERTs editor is dirty (has uncommitted changes) and the user takes any action that would close the INSERTs editor.

Off the top of my head these actions could include:
* Switching to a different tab in the table editor
* Opening a different table in the table editor

The default behavior is to discard all uncommitted changes without warning.

How to repeat:
Go to the INSERTs editor for a table, enter a few rows to insert.  Do not click the tick button to commit these changes.

Either switch to a different tab in the table editor or open a different table in the editor.

Upon returning to the INSERTs editor these changes have gone.

[15 Jan 2010 16:01] Johannes Taxacher

this actually only applies to the linux version, as both windows and osx version warn you when trying to close the table editor with pending changes in inserts-grid.

[25 Mar 2010 14:39] Mike Lischke

Increasing severity. This problem can lead to data loss and that justifies a higher severity.

[10 Apr 2010 4:05] Alfredo Kojima

Added confirmation in Linux and Mac.

[8 May 2010 3:03] Alfredo Kojima

The big bug here was that switching tabs inside the table editor in Linux would reset the contents of the inserts editor. That has been fixed.

[10 May 2010 23:23] Johannes Taxacher

only a minor case left where you can still close editor with uncommitted data. you can still close the main model tab without being warned/asked about pending changes.

[24 Jan 2013 22:51] Philip Olson

Fixed as of the upcoming MySQL Workbench 5.2.46 release, and here's the changelog entry:

On Linux, a warning will now warn you after attempting to close the SQL
Editor when unsaved "INSERT" changes still exist. 

Also, all platforms (Linux, Mac OS X, Windows) are now consistent, and will 
also warn you after attempting to close MySQL Workbench with any unsaved 
changes.

Thank you for the bug report.