Bug #49925 Can forget to Apply a change to data edits and Crashes
Submitted: 24 Dec 2009 17:39 Modified: 15 Jan 2010 15:33
Reporter: Mike Frank Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Workbench Severity:S2 (Serious)
Version:5.2.11 OS:Any (xp pro, Mac OS X)
Assigned to: Alfredo Kojima CPU Architecture:Any

[24 Dec 2009 17:39] Mike Frank 
Description:
in sql editor, no warning if you leave screen w/o commiting or discarding. 
Need a reminder dialog.

How to repeat:
go to sql editor.

right click EDIT city in sakila for example.

second row replace entire city name contents

Click on X for results tab for this.

Crash should occur

Suggested fix:
Need to make it clearer that a “change “ must be Applied (Commited).
Currently can go away from screen w/o reminder.

Add a reminder on close of edited results tab.

You are closing an edited results screen and you have neither committed, rolledback or discarded your changes.  

OK. Just leaves. Cancel - leaves screen up so user can commit etc.
[24 Dec 2009 18:07] Valeriy Kravchuk 
Thank you for the problem report. Verified just as described.
[30 Dec 2009 15:27] Alfredo Kojima 
The crash in Windows has already been fixed by Sergei.
[30 Dec 2009 15:44] Alfredo Kojima 
Added a confirmation dialog to closing resultsets in Mac.
[7 Jan 2010 13:54] Johannes Taxacher 
fix confirmed. 
only 2 small issues left:
- user is not prompted for action when trying to close whole query tab while having pending changes
- when user enters invalid data into grid and closes edit tab, and chooses to "apply" the data, commit fails and leaves the grid open (no info on why it didnt commit/close at this point)
[13 Jan 2010 15:45] Johannes Taxacher 
fix confirmed. will be included in 5.2.12
[15 Jan 2010 15:33] Tony Bedford 
A 'change' entry has been added to the 5.2.12 changelog:

In the SQL Editor, if a table was edited with the Edit Data facility, and table values changed, no warning was given if an attempt was made to close the tab without having first applied changes using the apply button.

MySQL Workbench has been changed so that if the user attempts to close a live editing tab, without having applied any changes made, then a warning dialog is displayed.