MySQL Bugs: #49860: new compiler warning ha

Bug #49860	new compiler warning ha_archive
Submitted:	21 Dec 2009 21:00	Modified:	13 Mar 2010 17:46
Reporter:	Magnus Blåudd	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Archive storage engine	Severity:	S3 (Non-critical)
Version:	mysql-5.1	OS:	Windows
Assigned to:	Davi Arnaut	CPU Architecture:	Any

Description:
7>ha_archive.cc
7>.\ha_archive.cc(1493) : warning C4244: '=' : conversion from 'ulonglong' to 'ulong', possible loss of data

ha_archive.cc>>
    stats.mean_rec_length= stats.records ?
      stats.data_file_length / stats.records : table->s->reclength;

How to repeat:
compiler warning & MCI

Suggested fix:
    stats.mean_rec_length= stats.records ?
      ulong(stats.data_file_length / stats.records) : table->s->reclength;

Thank you for the report.

I have no such a warning in compile logs. Which tree, compiler and configure options do you use?

Sorry forgot that part, it's with Microsoft Visual Studio 2008 on Windows. The mysql-5.1 tree.

Thank you for the bug report.

1>Compiling...
1>ha_archive.cc
1>c:\build\5.1\sql\sql_class.h(651) : warning C4267: 'return' : conversion from 'size_t' to 'uint32', possible loss of data
1>.\ha_archive.cc(682) : warning C4267: 'argument' : conversion from 'size_t' to 'unsigned int', possible loss of data
1>.\ha_archive.cc(1173) : warning C4267: 'argument' : conversion from 'size_t' to 'uint32', possible loss of data
1>.\ha_archive.cc(1194) : warning C4267: 'argument' : conversion from 'size_t' to 'uint32', possible loss of data
1>.\ha_archive.cc(1493) : warning C4244: '=' : conversion from 'ulonglong' to 'ulong', possible loss of data
1>Build log was saved at "file://c:\build\5.1\storage\archive\archive.dir\Release\BuildLog.htm"
1>archive - 0 error(s), 5 warning(s)
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/95993

Pushed into 5.1.41-ndb-7.0.11 (revid:magnus.blaudd@sun.com-20100105153510-so83tyaxrtioxck7) (version source revid:magnus.blaudd@sun.com-20100105153510-so83tyaxrtioxck7) (merge vers: 5.1.41-ndb-7.0.11) (pib:15)

Pushed into 5.1.41-ndb-7.1.0 (revid:jonas@mysql.com-20100106154839-irfws0q3tz7ur6a2) (version source revid:jonas@mysql.com-20100106154839-irfws0q3tz7ur6a2) (merge vers: 5.1.41-ndb-7.1.0) (pib:15)

Queued to 5.1-bugteam.

Cosmetic change, no need for changelog entry.

Pushed into 5.1.44 (revid:joro@sun.com-20100204101444-2j32mhqroo0iiio6) (version source revid:davi.arnaut@sun.com-20100121002220-hycqwoeyv23y6wul) (merge vers: 5.1.43) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100204063540-9czpdmpixi3iw2yb) (version source revid:alik@sun.com-20100127221310-2pnrwf5hmkhweqrm) (pib:16)

Pushed into 6.0.14-alpha (revid:alik@sun.com-20100205113942-oqovjy0eoqbarn7i) (version source revid:alik@sun.com-20100204064210-ljwanqvrjs83s1gq) (merge vers: 6.0.14-alpha) (pib:16)

Pushed into 5.5.2-m2 (revid:alik@sun.com-20100203172258-1n5dsotny40yufxw) (version source revid:alexey.kopytov@sun.com-20100123210923-lx4o1ettww9fdkqk) (merge vers: 5.5.2-m2) (pib:16)

No changelog entry needed.

Pushed into 5.1.44-ndb-7.0.14 (revid:jonas@mysql.com-20100312135944-t0z8s1da2orvl66x) (version source revid:jonas@mysql.com-20100312115609-woou0te4a6s4ae9y) (merge vers: 5.1.44-ndb-7.0.14) (pib:16)

Pushed into 5.1.44-ndb-6.2.19 (revid:jonas@mysql.com-20100312134846-tuqhd9w3tv4xgl3d) (version source revid:jonas@mysql.com-20100312060623-mx6407w2vx76h3by) (merge vers: 5.1.44-ndb-6.2.19) (pib:16)

Pushed into 5.1.44-ndb-6.3.33 (revid:jonas@mysql.com-20100312135724-xcw8vw2lu3mijrhn) (version source revid:jonas@mysql.com-20100312103652-snkltsd197l7q2yg) (merge vers: 5.1.44-ndb-6.3.33) (pib:16)

No changelog entry needed.