MySQL Bugs: #49296: Failed data exports don't get cleaned up

Bug #49296	Failed data exports don't get cleaned up
Submitted:	1 Dec 2009 20:32	Modified:	17 Dec 2009 15:20
Reporter:	Todd Farmer (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench	Severity:	S1 (Critical)
Version:	5.2.10 r4680	OS:	Windows (XP)
Assigned to:	Alexander Musienko	CPU Architecture:	Any

Description:
When a data export fails (example in Bug #49295), WB leaves the corresponding SQL file in whatever state it was.  This causes problems, because there's no indication at the file level that this is an unsuccessful/invalid backup - one has to examine the contents outside of WB to validate.

In my case, I took the failed backup from Bug #49295 (forgot it failed before generating the table structure) and tried to import it.  It succeeded, of course, but it had no impact, since there was no DROP/CREATE TABLE statement included.

All told, there is *nothing* which indicates to me that my data import was a no-op.

How to repeat:
See above.

Suggested fix:
When the backup fails, delete the incomplete backup file.

this is fixed in repository.
will be included in 5.2.11

An entry has been added to the 5.2.11 changelog:

When a export was performed via the Data Dump tab of the Admin screen, and the export failed, the resultant SQL file was not deleted.