MySQL Bugs: #49274: "make dist" doesn't work

Bug #49274	"make dist" doesn't work
Submitted:	1 Dec 2009 16:46	Modified:	5 Feb 2013 3:19
Reporter:	Hartmut Holzgraefe	Email Updates:
Status:	Won't fix	Impact on me:	None
Category:	MySQL Workbench	Severity:	S3 (Non-critical)
Version:	workbench-5.2 bzr	OS:	Linux
Assigned to:		CPU Architecture:	Any

Description:
"make dist" fails as the Makefile in ext/ctemplate does not have a "distdir" target. It is currently a hand coded minimalistic Makefile that does not play nice with the automake generated ones around it ...

How to repeat:
unpack workbench, run:

./autogen.sh
make
make dist

Suggested fix:
Have the ext/ctemplate be generated by automake or at least have all required make targets handled inside

several problems with "make dist":

- one Makefile not under automake control, so missing "dist" and other autotools targets
- path names too long for standard tar (>99 characters total), ustar format needed
- .cpppp instead of .ccp file endings in library/sql-parser/source/Makefile.am 
  (no idea if this change was an intentional workaround for something or a typo)

the patch below makes "make dist" work as in "no errors", a "make distcheck" still fails though so the generated source distribution tarball is most likely broken ... will file a new bug report for this

=== modified file 'configure.in'
--- configure.in        2009-11-30 11:47:56 +0000
+++ configure.in        2009-12-01 23:37:45 +0000
@@ -1,6 +1,6 @@
 AC_INIT(mysql-workbench, 5.2.10)
 AC_CONFIG_SRCDIR(backend/wbpublic/grt/common.h)
-AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
+AM_INIT_AUTOMAKE([1.9 tar-ustar])

 AC_CONFIG_HEADER(config.h)

@@ -376,6 +376,7 @@ ext/Makefile
 ext/scintilla/gtk/Makefile
 ext/cppconn/Makefile
 ext/cppconn/driver/Makefile
+ext/ctemplate/Makefile
 backend/Makefile
 backend/wbpublic/Makefile
 backend/wbprivate/Makefile

=== removed file 'ext/ctemplate/Makefile'
--- ext/ctemplate/Makefile      2009-08-21 08:24:51 +0000
+++ ext/ctemplate/Makefile      1970-01-01 00:00:00 +0000
@@ -1,15 +0,0 @@
-
-all:
-       make -C ctemplate-src libctemplate_wb.la
-
-clean:
-#      make -C ctemplate-src clean
-
-distclean:
-#      make -C ctemplate-src distclean
-
-install:
-       make -C ctemplate-src install-libLTLIBRARIES
-
-uninstall:
-#      make -C ctemplate-src uninstall

=== added file 'ext/ctemplate/Makefile.am'
--- ext/ctemplate/Makefile.am   1970-01-01 00:00:00 +0000
+++ ext/ctemplate/Makefile.am   2009-12-01 16:53:14 +0000
@@ -0,0 +1 @@
+SUBDIRS=ctemplate-src

=== modified file 'library/sql-parser/source/Makefile.am'
--- library/sql-parser/source/Makefile.am       2009-09-25 11:47:30 +0000
+++ library/sql-parser/source/Makefile.am       2009-12-01 19:12:49 +0000
@@ -27,11 +27,11 @@ libsqlparser_la_SOURCES=\
        ctype-win1250ch.cpp\
        ctype.cpp\
        int2str.cpp\
-       myx_lex_helpers.cpppp\
-       myx_sql_tree_item.cpppp\
-       myx_statement_parser.cpppp\
-       myx_unicode_scanner.cpppp\
-       sql_parser_symbols.cpppp\
+       myx_lex_helpers.cpp\
+       myx_sql_tree_item.cpp\
+       myx_statement_parser.cpp\
+       myx_unicode_scanner.cpp\
+       sql_parser_symbols.cpp\
        my_messnc.cpp\
        my_static.cpp\
        my_strtoll10.cpp\

Build system will be replaced with cmake