Description:
There is
1. an apparent disagreement in the way how --log-warnings server option is defined between the source code
mysqld.cc:
{"log-warnings", 'W', "Log some not critical warnings to the log file.",
and the doc pages:
* `--log-warnings[=LEVEL]', `-W [LEVEL]'
mentioning LEVELs. LEVELs are not explained in that section of the docs although
there is an indirect def at `show-warnings' sql command to make one
think of "Level: Note" or "Level: Warning" or "Level: Error".
2. Lack of clear semantics of --log-warnings hurts in many ways as to the
user so to the programmer (e.g consider discussions around bug#42851).
It's not quite clear from the existing use cases what is "some" in the source code sense. On one hand --log-warnings tries
to error-log messages that user can not receive via client-server protocol
(show warnings) such as ` Aborted connection ', oth recently the set of cases gained error-logging of "Statement is not safe to log..." replication warning
bug#46265.
How to repeat:
To follow the description to read the lines of the code and the docs.
Suggested fix:
First,
to define --log-warnings to deal with the LEVEL as defined per
`show-warnings'. E.g the following dbug-like
syntax can be offered (per Luis):
--log-warnings=-error,+warning,+note
to mean to disable the error level messages and enable
the warning and the note level ones for error-logging.
Second,
to elaborate on --log-warning to accept a particular error code
--log-warnings=-error:4711,1001,+note:1001
The template line excludes error-logging of the error 4711 and to forces it for the note 1001.
Third,
notice that the fine-granularity filtering can be possible only if all the messages will be enumerated. Let's enumerate `Aborted connection' etc (if they are not yet) and make such administration errors be error-loggable by default.
Description: There is 1. an apparent disagreement in the way how --log-warnings server option is defined between the source code mysqld.cc: {"log-warnings", 'W', "Log some not critical warnings to the log file.", and the doc pages: * `--log-warnings[=LEVEL]', `-W [LEVEL]' mentioning LEVELs. LEVELs are not explained in that section of the docs although there is an indirect def at `show-warnings' sql command to make one think of "Level: Note" or "Level: Warning" or "Level: Error". 2. Lack of clear semantics of --log-warnings hurts in many ways as to the user so to the programmer (e.g consider discussions around bug#42851). It's not quite clear from the existing use cases what is "some" in the source code sense. On one hand --log-warnings tries to error-log messages that user can not receive via client-server protocol (show warnings) such as ` Aborted connection ', oth recently the set of cases gained error-logging of "Statement is not safe to log..." replication warning bug#46265. How to repeat: To follow the description to read the lines of the code and the docs. Suggested fix: First, to define --log-warnings to deal with the LEVEL as defined per `show-warnings'. E.g the following dbug-like syntax can be offered (per Luis): --log-warnings=-error,+warning,+note to mean to disable the error level messages and enable the warning and the note level ones for error-logging. Second, to elaborate on --log-warning to accept a particular error code --log-warnings=-error:4711,1001,+note:1001 The template line excludes error-logging of the error 4711 and to forces it for the note 1001. Third, notice that the fine-granularity filtering can be possible only if all the messages will be enumerated. Let's enumerate `Aborted connection' etc (if they are not yet) and make such administration errors be error-loggable by default.