Bug #48698 Charset introducer in query constructor
Submitted: 11 Nov 2009 20:05 Modified: 11 Mar 2010 17:29
Reporter: Tonci Grgin Email Updates:
Status: Closed Impact on me:
None 
Category:Connector / ODBC Severity:S4 (Feature request)
Version:all OS:Any
Assigned to: Lawrenty Novitsky CPU Architecture:Any

[11 Nov 2009 20:05] Tonci Grgin 
Description:
Looking into code we see that for
case SQL_CHAR:
case SQL_VARCHAR:
case SQL_LONGVARCHAR:
case SQL_BINARY:
case SQL_VARBINARY:
case SQL_LONGVARBINARY:
case SQL_WCHAR:
case SQL_WVARCHAR:
case SQL_WLONGVARCHAR:
c/odbc adds _(charsetname) when constructing query.

For
case SQL_BINARY:
case SQL_VARBINARY:
case SQL_LONGVARBINARY:
it should slap _binary in front and not _(charsetname).

How to repeat:
Check the code.

Suggested fix:
-
[13 Nov 2009 17:19] Lawrenty Novitsky 
Patch and chngelog entry. Couldn't think of testcase - we don't know any case when something worked wrongly because of this bug.

Attachment: bug48698.diff (text/x-diff), 1.34 KiB.
[13 Nov 2009 17:22] Lawrenty Novitsky 
Maybe _binary introducer should be unconditional for binary data. So far I decided to leave different charsets condition.
[11 Mar 2010 17:29] Lawrenty Novitsky 
this patch has already been pushed as part of Bug#49029 patch. so i'm just closing the bug