Bug #47337 innochecksum not built for --with-plugin-innodb_plugin --without-plugin-innobase
Submitted: 15 Sep 2009 19:42 Modified: 29 Aug 2011 13:53
Reporter: Mark Callaghan Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.1.40 OS:Any
Assigned to: Joerg Bruehe CPU Architecture:Any
Tags: 5.1.40, Contribution, innodb, plugin
Triage: Triaged: D3 (Medium)

[15 Sep 2009 19:42] Mark Callaghan
Description:
innochecksum is not build for 'configure --with-plugin-innodb_plugin --without-plugin-innobase'. A patch is provided to fix that.

How to repeat:
Run: configure --with-plugin-innodb_plugin --without-plugin-innobase

Suggested fix:
--- a/configure.in
+++ b/configure.in
@@ -2719,7 +2719,7 @@ then
     MAN_DROP="$MAN_DROP embedded"
     grep -v 'embedded' $MANLISTFIL > $TMPLISTFIL ; mv -f $TMPLISTFIL $MANLISTFIL
   fi
-  if test X"$with_plugin_innobase" != Xyes
+  if test X"$with_plugin_innobase" != Xyes -a test X"$with_plugin_innodb_plugin" != Xyes
   then
     MAN_DROP="$MAN_DROP innodb"
     grep -v 'inno' $MANLISTFIL > $TMPLISTFIL ; mv -f $TMPLISTFIL $MANLISTFIL
@@ -2793,7 +2793,7 @@ then
 fi
 
 # "innochecksum" is not in the "innobase/" subdirectory, but should be switched
-AM_CONDITIONAL([BUILD_INNODB_TOOLS], [test X"$with_plugin_innobase" = Xyes])
+AM_CONDITIONAL([BUILD_INNODB_TOOLS], [test X"$with_plugin_innobase" = Xyes -o test X"$with_plugin_innodb_plugin" = Xyes])
 
 # IMPORTANT - do not modify LIBS past this line - this hack is the only way
 # I know to add the static NSS magic if we have static NSS libraries with

--- a/configure
+++ b/configure
@@ -48810,7 +48810,7 @@ $as_echo_n "checking \"for man pages to remove\"... " >&6; }
     MAN_DROP="$MAN_DROP embedded"
     grep -v 'embedded' $MANLISTFIL > $TMPLISTFIL ; mv -f $TMPLISTFIL $MANLISTFIL
   fi
-  if test X"$with_plugin_innobase" != Xyes
+  if test X"$with_plugin_innobase" != Xyes -a test X"$with_plugin_innodb_plugin" != Xyes
   then
     MAN_DROP="$MAN_DROP innodb"
     grep -v 'inno' $MANLISTFIL > $TMPLISTFIL ; mv -f $TMPLISTFIL $MANLISTFIL
@@ -48904,7 +48904,7 @@ _ACEOF
 fi
 
 # "innochecksum" is not in the "innobase/" subdirectory, but should be switched
- if test X"$with_plugin_innobase" = Xyes; then
+ if test X"$with_plugin_innobase" = Xyes -o test X"$with_plugin_innodb_plugin" = Xyes; then
   BUILD_INNODB_TOOLS_TRUE=
   BUILD_INNODB_TOOLS_FALSE='#'
 else
[15 Sep 2009 20:27] Sveta Smirnova
Thank you for the report.

Verified as described.
[16 Sep 2009 17:24] Mark Callaghan
The patch has 2 typos. Change '-a test ...' -> '-a ...' and '-o test ...' -> '-o ...'
[8 Jul 2011 14:33] Joerg Bruehe
I verified the proposed patch achieves the desired effect
(that was to be expected).
[15 Jul 2011 10:35] Jonathan Perkin
Approved.
[16 Aug 2011 20:17] Joerg Bruehe
Patch is pushed into the sources for 5.1.60.

This affects 5.1 only, no other version, as no other has the InnoDB plugin.
Upmerge to 5.5 and 5.6 is done as a "null" merge, no change.
[29 Aug 2011 13:53] Paul Dubois
Noted in 5.1.60 changelog.

If MySQL was configured with --without-plugin-innobase and
--with-plugin-innodb_plugin, to suppress building the built-in InnoDB
storage engine and build the InnoDB Plugin instead, the innochecksum
utility was not built.