Bug #46674 5.1: make abi_check_all fails.

• Submitted: 12 Aug 2009 13:13
• Modified: 15 Aug 2009 9:07
• Reporter: Konstantin Osipov (OCA)
• Status: Won't fix
• Category: MySQL Server: Storage Engine API
• Severity: S3 (Non-critical)
• Version: 5.1
• OS: Any
• CPU Architecture: Any

[12 Aug 2009 13:13] Konstantin Osipov

Description:
mysql_priv.h.pp has changed significantly since last update.
make abi_check_all thus fails.

How to repeat:
make abi_check_all

[12 Aug 2009 13:16] Konstantin Osipov

We need to freeze the PSEA ABI in 5.1 at this point: update this file and keep the ABI intact after that.

[12 Aug 2009 13:17] Konstantin Osipov

In 5.4 ABI is still different from 5.1, so there I think we could keep making changes until GA.

[12 Aug 2009 13:27] MySQL Verification Team

Thank you for the bug report.

[15 Aug 2009 9:07] Sergei Golubchik

mysql_priv.h.pp doesn't specify the ABI, if you look at it you'll see lots of code which clearly isn't ABI. For example inlined methods in the handler class.

That's why mysql_priv.h.pp isn't part of the regular "make abi_check" and part of "make all". It is simply not ready for it yet.

Mats' work on removing mysql_priv.h will help, though.