Bug #46286 Undo wrong action undone
Submitted: 18 Jul 2009 18:39 Modified: 11 Jun 2010 13:21
Reporter: Karsten Wutzke Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Workbench: Modeling Severity:S3 (Non-critical)
Version:5.2.1alpha, 5.2.2 OS:Windows (XP)
Assigned to: Mike Lischke CPU Architecture:Any
Tags: column, Edit Table, paste, undo

[18 Jul 2009 18:39] Karsten Wutzke 
Description:
Open any model, do any action that is visually visible (like moving a table), copy some text into the clipboard, edit a table, click the column tab, double-click any column. Now paste the copied text as new column name.

When pressing undo (Ctrl-Shift-Z) the table move and not the paste is undone. This is the wrong behavior.

How to repeat:
see desc

Suggested fix:
You probably forgot to put the paste action into the undo list.
[18 Jul 2009 22:32] MySQL Verification Team 
I couldn't repeat this issue on Windows Vista.
[27 Jul 2009 7:46] Susanne Ebrecht 
Many thanks for writing a bug report.

I am confused about the key combination CTRL-SHIFT-Z.

On German keyboard undo should be STRG-z (CTRL-z) means without SHIFT.

What do you expect the SHIFT-z should do?
[1 Aug 2009 12:14] Karsten Wutzke 
Hmmm I am using Windows XP, maybe it works there. The keyboard focus had to be inside the cell, don't press RETURN or anything before undoing.
[3 Aug 2009 8:14] Susanne Ebrecht 
Karsten,

CTRL-z is "Undo"
CTRL-Shift-z is "Redo"

Could it be that you mixed something here?
[4 Aug 2009 15:23] Karsten Wutzke 
I mixed it up in my original bug report, but I corrected the synopsis etc. I meant the REDO accelerator. I think Ctrl-Shift-Z is unintuitive. Almost all applications use

Ctrl-Y

for it.
[4 Aug 2009 15:26] Karsten Wutzke 
Forget my last entry, I did another bug report with the REDO accelerator.

Now I get this one straight. When typing inside a cell, with the focus inside the text field, e.g. a column rename, pressing UNDO (Ctrl-Z) won't undo the just made typing but some other action before editing.

I would expect to undo the typing not the action before I started this...
[5 Aug 2009 7:26] Valeriy Kravchuk 
Verified just as described in the last comment with WB 5.2.2 on XP. As a workaround, click somewhere outside the field before pressing Ctrl-Z.
[8 Jun 2010 21:06] Johannes Taxacher 
fix confirmed in repository
[11 Jun 2010 13:21] Tony Bedford 
An entry has been added to the 5.2.23 changelog:

When editing a column in the table editor, pressing CTRL + Z to undo the edit resulted in a previous operation being undone instead.